Re: ole32: Print error message when IPersistStorage_Load fails (Coverity)

[Nikolay Sivov]

On 23.11.2015 22:26, André Hentschel wrote:
> Signed-off-by: André Hentschel
>
> CID 1336207
>
> dlls/ole32/compobj.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c
> index 2f55076..b146376 100644
> --- a/dlls/ole32/compobj.c
> +++ b/dlls/ole32/compobj.c
> @@ -3443,7 +3443,9 @@ HRESULT WINAPI CoGetInstanceFromIStorage(
> if (ps)
> {
> -
>  IPersistStorage_Load(ps, storage);
> -
>  hr = IPersistStorage_Load(ps, storage);
> -
>  if (FAILED(hr))
> -
>      ERR("failed to load storage\n");
>   IPersistStorage_Release(ps);
> }

The question is what to do on this failure, that's a point of Coverity 
warning.

ole32: Print error message when IPersistStorage_Load fails (Coverity)

[André Hentschel]

Am 23.11.2015 um 20:30 schrieb Nikolay Sivov:
> On 23.11.2015 22:26, André Hentschel wrote:
> > Signed-off-by: André Hentschel
> >
> > CID 1336207
> >
> > dlls/ole32/compobj.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c
> > index 2f55076..b146376 100644
> > --- a/dlls/ole32/compobj.c
> > +++ b/dlls/ole32/compobj.c
> > @@ -3443,7 +3443,9 @@ HRESULT WINAPI CoGetInstanceFromIStorage(
> > if (ps)
> > {
> > -
> >  IPersistStorage_Load(ps, storage);
> > -
> >  hr = IPersistStorage_Load(ps, storage);
> > -
> >  if (FAILED(hr))
> > -
> >      ERR("failed to load storage\n");
> >   IPersistStorage_Release(ps);
> > }
>
> The question is what to do on this failure, that's a point of Coverity warning.

I thought we first should be able to notice it when it happens, but of course you're absolute correct.
Let's see