Re: [v3 09/10] wined3d: don't pass a wined3d_volume to device_volume_created callback anymore

[Henri Verbeet]

On 6 October 2015 at 10:36, Riccardo Bortolato  wrote:
> diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h
> index a354308..f1ead48 100644
> --- a/include/wine/wined3d.h
> +++ b/include/wine/wined3d.h
> @@ -2034,7 +2034,7 @@ struct wined3d_device_parent_ops
>              struct wined3d_surface *surface, void **parent, const struct wined3d_parent_ops **parent_ops);
>      HRESULT (__cdecl *volume_created)(struct wined3d_device_parent *device_parent,
>              struct wined3d_texture *wined3d_texture, unsigned int sub_resource_idx,
> -
>        struct wined3d_volume *volume, void **parent, const struct wined3d_parent_ops **parent_ops);
> -
>        void **parent, const struct wined3d_parent_ops **parent_ops);

I think you should be able to remove the forward declaration of struct
wined3d_volume as well now.

[v3 09/10] wined3d: don't pass a wined3d_volume to device_volume_created callback anymore

[Riccardo Bortolato]

Whoops, I missed this as well as the DECLSPEC_HIDDEN thing.

I'll test and resend.

Ciao,
Riccardo

2015-10-07 18:11 GMT+02:00 Henri Verbeet :
> On 6 October 2015 at 10:36, Riccardo Bortolato  wrote:
> > diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h
> > index a354308..f1ead48 100644
> > --- a/include/wine/wined3d.h
> > +++ b/include/wine/wined3d.h
> > @@ -2034,7 +2034,7 @@ struct wined3d_device_parent_ops
> >              struct wined3d_surface *surface, void **parent, const struct wined3d_parent_ops **parent_ops);
> >      HRESULT (__cdecl *volume_created)(struct wined3d_device_parent *device_parent,
> >              struct wined3d_texture *wined3d_texture, unsigned int sub_resource_idx,
> > -
> >        struct wined3d_volume *volume, void **parent, const struct wined3d_parent_ops **parent_ops);
> > -
> >        void **parent, const struct wined3d_parent_ops **parent_ops);
>
> I think you should be able to remove the forward declaration of struct
> wined3d_volume as well now.