Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=12501
I've implemented some of the functions in mspatcha.dll, including ApplyPatchToFileW. I'm currently writing tests, but patch creation is not implemented, so only Windows can generate patch test files. How does testing normally work in this situation? It is possible to embed some very small test files as strings within the source code. A crosstest build should work too. Any other suggestions? I am not yet very familiar with the code base.
Regards, Conor
On Fri, Apr 12, 2019 at 2:39 PM Conor McCarthy conor.mccarthy.444@gmail.com wrote:
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=12501
I've implemented some of the functions in mspatcha.dll, including ApplyPatchToFileW. I'm currently writing tests, but patch creation is not implemented, so only Windows can generate patch test files. How does testing normally work in this situation? It is possible to embed some very small test files as strings within the source code. A crosstest build should work too. Any other suggestions? I am not yet very familiar with the code base.
Hello Conor.
Nice! I guess the ideal solution would be to implement patch generation first and then use that to runtime generate the test patches. If that's unpractical, small test patches embedded in the source code or in the resources of the test should be okay. There are multiple examples of that in Wine, e.g. see create_file() in dlls/d3dx9_36/tests/asm.c.
Cheers, Matteo.
-
Conor McCarthy -
Matteo Bruni