On Tue, Apr 10, 2012 at 21:13, Bruno Jesus 00cpxxx@gmail.com wrote:
- Added a final required test for the h->h_addr_list[0] to show we
must put it in the right place.
- Removed the cached use of older gethostbyname result since the
memory is static and turned into garbage in windows if the current call fails.
- Added a skip if we hit older OS allowing we to avoid using broken()
on each test.
+ if(h->h_addr_list == addr.mem) /* <= W2K */ + { + skip("Skipping hostent tests since this OS is unsupported\n"); + return; + } +
You should use win_skip so that the tests will only be skipped on windows (we'd want the failure to be exposed on wine).
On Wed, Apr 11, 2012 at 15:05, Austin English austinenglish@gmail.com wrote:
On Tue, Apr 10, 2012 at 21:13, Bruno Jesus 00cpxxx@gmail.com wrote: You should use win_skip so that the tests will only be skipped on windows (we'd want the failure to be exposed on wine).
You mean I should use win_skip and remove the return so the flow goes on in wine? Will win_skip return automatically?
-- -Austin
Regards, Bruno
On Wed, Apr 11, 2012 at 13:27, Bruno Jesus 00cpxxx@gmail.com wrote:
On Wed, Apr 11, 2012 at 15:05, Austin English austinenglish@gmail.com wrote:
On Tue, Apr 10, 2012 at 21:13, Bruno Jesus 00cpxxx@gmail.com wrote: You should use win_skip so that the tests will only be skipped on windows (we'd want the failure to be exposed on wine).
You mean I should use win_skip and remove the return so the flow goes on in wine? Will win_skip return automatically?
No, just change the skip to win_skip. On windows, the test will be skipped, then you will return. On wine, the test will fail, so we can no that some behavior broke (from changed code or otherwise). You'll still return, but without that change, the failure will not be noticed.
-
Austin English -
Bruno Jesus