Re: [PATCH] dwrite: use correct variable (Coverity)

[Nikolay Sivov]

On 9/21/2014 16:35, Marcus Meissner wrote:
> 1232720 Mixing enum types
> these are actually different values.
>
> dlls/dwrite/tests/font.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/dwrite/tests/font.c b/dlls/dwrite/tests/font.c
> index 3a17064..fe4eb4b 100644
> --- a/dlls/dwrite/tests/font.c
> +++ b/dlls/dwrite/tests/font.c
> @@ -957,7 +957,7 @@ static void test_FontLoader(void)
>       ok(face == DWRITE_FONT_FACE_TYPE_UNKNOWN, "got %i\n", face);
>       ok(count == 0, "got %i\n", count);
> - hr = IDWriteFactory_CreateFontFace(factory, type, 1, &ffile, 0, 0, &fface);
> - hr = IDWriteFactory_CreateFontFace(factory, face, 1, &ffile, 0, 0, &fface);
>  ok(hr == 0x8faecafe, "got 0x%08x\n", hr);
>  IDWriteFontFile_Release(ffile);

It's supposed to be DWRITE_FONT_FACE_TYPE_CFF (it is now) or 
DWRITE_FONT_FACE_TYPE_TRUETYPE.

[PATCH] dwrite: use correct variable (Coverity)

[Marcus Meissner]

On Sun, Sep 21, 2014 at 06:17:02PM +0400, Nikolay Sivov wrote:
> On 9/21/2014 16:35, Marcus Meissner wrote:
> > 1232720 Mixing enum types
> > these are actually different values.
> >
> > dlls/dwrite/tests/font.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/dlls/dwrite/tests/font.c b/dlls/dwrite/tests/font.c
> > index 3a17064..fe4eb4b 100644
> > --- a/dlls/dwrite/tests/font.c
> > +++ b/dlls/dwrite/tests/font.c
> > @@ -957,7 +957,7 @@ static void test_FontLoader(void)
> >      ok(face == DWRITE_FONT_FACE_TYPE_UNKNOWN, "got %i\n", face);
> >      ok(count == 0, "got %i\n", count);
> > - hr = IDWriteFactory_CreateFontFace(factory, type, 1, &ffile, 0, 0, &fface);
> > - hr = IDWriteFactory_CreateFontFace(factory, face, 1, &ffile, 0, 0, &fface);
> > ok(hr == 0x8faecafe, "got 0x%08x\n", hr);
> > IDWriteFontFile_Release(ffile);
>
> It's supposed to be DWRITE_FONT_FACE_TYPE_CFF (it is now) or
> DWRITE_FONT_FACE_TYPE_TRUETYPE.

ah ok. resubmitted with CFF constant.

Ciao, Marcus