Re: Small fixes in controls/menu.c

[gerard patel]

At 03:35 AM 18/05/2001 +0200, you wrote:
> Application Super Memo 8 has two modes of functioning. One  mulit-document
> (using MDI)  and the other single-document.

<snip>
> Second Problem:
> Also occurs at switching between modes.
> The menu is displayed at improper place (about 10-20 pixels upper than it
> should).
> I think the problem is in the function MENU_InitTracking in code :

<snip one of my patches>

My patch is certainly not positioning the menu correctly in the case of your
app, and your patch fixes the app I did this patch for all right,  but I am wondering
if  calling SetWindowPos could not generate infinite loops in some cases.

Is Super Memo 8 available on the web as a demo app (freely downloable) ?

Also vs your ignored patch, I don't know - only Alexandre Julliard is judge and
executioner of all that is posted to wine-patches - but in such cases check always if
your  patch applies; if it does not, either because you did a mistake or the cvs code
was changed too much between the creation of your sandbox and the moment he looked 
at your patch, it could be the reason.

Gerard

Small fixes in controls/menu.c

On Sat, May 19, 2001 at 11:07:19AM +0200, gerard patel wrote:
> At 03:35 AM 18/05/2001 +0200, you wrote:
>
> My patch is certainly not positioning the menu correctly in the case of your
> app, and your patch fixes the app I did this patch for all right,  but I am wondering
> if  calling SetWindowPos could not generate infinite loops in some cases.

I think it shouldn't generate infinite loops, but my patch could work 
improperly when app catches and doesn't pass to defwndproc  WM_NCCALCSIZE 
message. So I wrote next patch (attached to this e-mail). 
Any comments,hints ?

When WIN_FindWndPtr(hWnd) return a NULL pointer doesn't it means that 
something bad happens ?
> Is Super Memo 8 available on the web as a demo app (freely downloable) ?

At http://www.supermemo.com/ or ftp://ftp.supermemo.com/ftp/sm8zip.exe you 
can find demo version of that app. (I have full ;-) version).
But I'm not sure If it is the same version ,and that bug occurs.
It is hard to me to check it because I have only dial-up connection
to internet :-( .
Maciek