Re: kernel32/volume: Don't modify the last error in GetVolumeInformation

[Alexandre Julliard]

Alexandre Goujon  writes:
> @@ -729,6 +731,8 @@ BOOL WINAPI GetVolumeInformationW( LPCWSTR root, LPWSTR label, DWORD label_len,
>          }
>          else
>          {
> -
>        /* At this point, last error is ERROR_NOT_SUPPORTED. Restoring the previous one */
> -
>        SetLastError(lastError);

You should never need to do that sort of thing, there are no guarantees
about last error on success.

kernel32/volume: Don't modify the last error in GetVolumeInformation

[Alexandre Goujon]

On Tue, May 29, 2012 at 7:07 PM, Alexandre Julliard wrote:
> Alexandre Goujon  writes:
> > @@ -729,6 +731,8 @@ BOOL WINAPI GetVolumeInformationW( LPCWSTR root,
>
> LPWSTR label, DWORD label_len,
> >      }
> >      else
> >      {
> > -
> >        /* At this point, last error is ERROR_NOT_SUPPORTED.
>
> Restoring the previous one */
> > -
> >        SetLastError(lastError);
>
> You should never need to do that sort of thing, there are no guarantees
> about last error on success.
>
> --
> Alexandre Julliard
> [e-mail]

I know but The Sims 3 calls GetLastError very often (in the top 10), nearly
between each call, maybe to check if a specific error does (or doesn't)
occur.
It troubled me when I investigated a bug and I thought the cost was so low
that we could do it anyway.
But I know you are right, so just forget about it.

PS: FYI I tested it on WIndows and the last error is not changed (but it
doesn't matter as you said)