Re: [01/02] d3d9: update locked_rect only if wined3d_surface_map succeeds

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2909

Your paranoid android.

=== w864 (32 bit device) ===
device: unhandled exception c0000005 at 740D14C8

=== w864 (64 bit device) ===
device: unhandled exception c0000005 at 000007F84EDD90EB

[01/02] d3d9: update locked_rect only if wined3d_surface_map succeeds

[Lasse Rasinen]

Marvin  writes:
> Full results can be found at
> https://newtestbot.winehq.org/JobDetails.pl?Key=2909
> [...]
> === w864 (32 bit device) ===
> device: unhandled exception c0000005 at 740D14C8
>
> === w864 (64 bit device) ===
> device: unhandled exception c0000005 at 000007F84EDD90EB

I've had a look at the logs and as far as I can tell, the failing test
is not exercising the change I made. If anyone can shed some light on
this, I'd be happy to resubmit the patch with the improved test failure
reporting.

(Although my personal drive for this patch has gone down as the new OS X
has a new compiler that doesn't break it on unpatched master)

[01/02] d3d9: update locked_rect only if wined3d_surface_map succeeds

[Henri Verbeet]

On 27 October 2013 14:22, Lasse Rasinen  wrote:
> Marvin  writes:
> > Full results can be found at
> > https://newtestbot.winehq.org/JobDetails.pl?Key=2909
> > [...]
> > === w864 (32 bit device) ===
> > device: unhandled exception c0000005 at 740D14C8
> >
> > === w864 (64 bit device) ===
> > device: unhandled exception c0000005 at 000007F84EDD90EB
>
> I've had a look at the logs and as far as I can tell, the failing test
> is not exercising the change I made. If anyone can shed some light on
> this, I'd be happy to resubmit the patch with the improved test failure
> reporting.

I think that's from test_rtpatch() that Stefan removed in
9c19266a247a2f4e1f88a3258026af33c6cd6efc. I think all this patch needs
is to fix the warnings, and the improved failure messages.

[01/02] d3d9: update locked_rect only if wined3d_surface_map succeeds

[Lasse Rasinen]

Henri Verbeet  writes:
> > I've had a look at the logs and as far as I can tell, the failing test
> > is not exercising the change I made. If anyone can shed some light on
> > this, I'd be happy to resubmit the patch with the improved test failure
> > reporting.
>
> I think that's from test_rtpatch() that Stefan removed in
> 9c19266a247a2f4e1f88a3258026af33c6cd6efc. I think all this patch needs
> is to fix the warnings, and the improved failure messages.

Looks like it wasn't that:
https://newtestbot.winehq.org/JobDetails.pl?Key=3077&log_204=1#k204

Based on this "device.c:6759: this is the last test seen before the
exception" it'd be somewhere within test_update_volumetexture or
something after that.