Review request: real async for GetAsyncKeyState (bug #5623)

[Rafał Miłecki]

Hi,

This is my first wine patch and fix for bug #5623. This was tested and
works fine however I suspect this is not clean enought for commiting
to master.

Would be nice if you could review this and tell me what sould be done
better (and how?).

This patch adds new variable:
BYTE global_key_state_table[256];

to wineserver and two new entries in protocol:
/* Get global key state */
@REQ(get_global_key_state)
    int            key;           /* key */
@REPLY
    BYTE           value;         /* status of key */
@END

/* Set global key state */
@REQ(set_global_key_state)
    int            key;           /* key */
    BYTE           value;         /* status for key */
@END

That allows me to keep current *global* state of keyboard. Of course
this will works only for wine windows from current wineserver. This
was discussed in bug report and it is fine for reported applications.

The last think I done is using wineserver in
X11DRV_send_keyboard_input

[Rafał Miłecki]

Direct link to bug report:

http://bugs.winehq.org/show_bug.cgi?id=5623

[Philip Nilsson]

On Wed, May 07, 2008 at 08:49:34PM +0200, Rafał Miłecki wrote:
> Hi,
>
> This is my first wine patch and fix for bug #5623. This was tested and
> works fine however I suspect this is not clean enought for commiting
> to master.
>
> -- 
> Rafał Miłecki

Applying this patch causes my Wine to fail with: (the second time, as it
runs some font metric stuff once first)

err:process:start_wineboot failed to create wineboot event, expect trouble
    err:font:WineEngInit Failed to create font mutex
    err:system:get_volatile_regkey Can't create wine registry branch
    err:system:get_volatile_regkey Can't create wine registry branch
    err:system:get_volatile_regkey Can't create wine registry branch
    err:system:get_volatile_regkey Can't create wine registry branch
    err:system:get_volatile_regkey Can't create wine registry branch
    err:system:get_volatile_regkey Can't create wine registry branch
    err:rpc:DllMain Failed to create master mutex
    err:winecfg:initialize RegOpenKey failed on wine config key (6)
    err:winecfg:WinMain initialization failed, aborting

I assumed this was due to something that didn't recompile, but I made
the tree clean and reconfigured it, and compiled again.  No change.

I will investigate a bit further as this patch might be useful for an
application I have some problems with (I think it uses GetAsyncKeyState
for modifiers).