Vitaliy Margolen wrote:
The limits are: 20 lines for logs (fixme, trace, err, warn) 10 lines for back traces
Bugzilla/Bug.pm | 7 +++++++ template/en/default/global/user-error.html.tmpl | 4 ++++ 2 files changed, 11 insertions(+), 0 deletions(-)
So who is the one to commit this? Alexandre? Jeremy?
Vitaliy.
I must have missed this. This would be incredibly useful.
Does this affect all users though? Anastasius Focht would probably go over these limits but his comments are helpful.
Vitaliy Margolen wrote:
Vitaliy Margolen wrote:
The limits are: 20 lines for logs (fixme, trace, err, warn) 10 lines for back traces
Bugzilla/Bug.pm | 7 +++++++ template/en/default/global/user-error.html.tmpl | 4 ++++ 2 files changed, 11 insertions(+), 0 deletions(-)
So who is the one to commit this? Alexandre? Jeremy?
Vitaliy.
Ken Sharp wrote:
I must have missed this. This would be incredibly useful.
Does this affect all users though? Anastasius Focht would probably go over these limits but his comments are helpful.
Vitaliy Margolen wrote:
Vitaliy Margolen wrote:
The limits are: 20 lines for logs (fixme, trace, err, warn) 10 lines for back traces
Bugzilla/Bug.pm | 7 +++++++ template/en/default/global/user-error.html.tmpl | 4 ++++ 2 files changed, 11 insertions(+), 0 deletions(-)
So who is the one to commit this? Alexandre? Jeremy?
Vitaliy.
What is the purpose of that change? To reduce mailed amount or what? To improve readability of reports? Log quotation are very useful sometimes and this blocking only makes things harder for people who knows what they're pasting.
On new bug page we already have a rather big stop sign, if it isn't enough could we just add permissions to some bugzilla guys to wipe comments with logs pasted or it's out of bugzilla functionality?
Nikolay Sivov wrote:
What is the purpose of that change? To reduce mailed amount or what? To improve readability of reports? Log quotation are very useful sometimes and this blocking only makes things harder for people who knows what they're pasting.
http://bugs.winehq.org/show_bug.cgi?id=11115
On new bug page we already have a rather big stop sign, if it isn't enough could we just add permissions to some bugzilla guys to wipe comments with logs pasted or it's out of bugzilla functionality?
Attachments can be deleted, can comments be deleted?
Ken Sharp wrote:
Nikolay Sivov wrote:
What is the purpose of that change? To reduce mailed amount or what? To improve readability of reports? Log quotation are very useful sometimes and this blocking only makes things harder for people who knows what they're pasting.
There's nothing about why it's so important. These 25, 35 or 20 lines to allow means nothing. Actually I don't see any problem here, and, yes, I'm subscribed on wine-bugs list and this full log pasting occurs for 1 in 30 (maybe less a bit) new bugs reported.
On new bug page we already have a rather big stop sign, if it isn't enough could we just add permissions to some bugzilla guys to wipe comments with logs pasted or it's out of bugzilla functionality?
Attachments can be deleted, can comments be deleted?
I don't know, that's why I've asked.
On Thu, 11 Jun 2009 16:30:57 +0400, you wrote:
There's nothing about why it's so important. These 25, 35 or 20 lines to allow means nothing. Actually I don't see any problem here, and, yes, I'm subscribed on wine-bugs list and this full log pasting occurs for 1 in 30 (maybe less a bit) new bugs reported.
Agreeing 100% with that.
Rein.
Rein Klazes wrote:
On Thu, 11 Jun 2009 16:30:57 +0400, you wrote:
There's nothing about why it's so important. These 25, 35 or 20 lines to allow means nothing. Actually I don't see any problem here, and, yes, I'm subscribed on wine-bugs list and this full log pasting occurs for 1 in 30 (maybe less a bit) new bugs reported.
Agreeing 100% with that.
Reading each individual post via e-mail is not a problem. Going to bugzilla and trying to read through the entire bug is.
Yes the stop sign does help with new posts, but does absolutely nothing for people who post 100+ lines of their terminal output into old bugs and make them totally impossible to follow.
Again this patch does not completely stop all logs from being posted, only standard output of fixmes, errs, warns, etc (without thread IDs). This is on purpose as Anastasius almost always adds +tid to the mix. And even allows some number of standard log lines, quite enough for quotation.
The fact that we get 1 in 30 doesn't mean we'll always see that much. It's much more common among first time reporters then anyone else. And number of new users will always go up.
Vitaliy.
On Thu, Jun 11, 2009 at 7:18 AM, Ken Sharpkennybobs@o2.co.uk wrote:
Attachments can be deleted, can comments be deleted?
No. They're archived all over the interwebs anyway, there is no point.
I support this patch.
-
Austin English -
Ken Sharp -
Nikolay Sivov -
Rein Klazes -
Vitaliy Margolen