[PATCH 5/5] winevulkan: Make core function thunks static.

[Jacek Caban]

Signed-off-by: Jacek Caban 
---
  dlls/winevulkan/make_vulkan | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

[Georg Lehmann]

On 31.05.21 16:17, Jacek Caban wrote:
> Signed-off-by: Jacek Caban
>
> dlls/winevulkan/make_vulkan | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/dlls/winevulkan/make_vulkan b/dlls/winevulkan/make_vulkan
> index 98a1e3ae2ac..14d0a04d341 100755
> --- a/dlls/winevulkan/make_vulkan
> +++ b/dlls/winevulkan/make_vulkan
> @@ -2660,8 +2660,7 @@ class VkGenerator(object):
>              if not vk_func.needs_thunk():
>                  continue
> -
>        # Exports symbols for Core functions.
> -
>        if not vk_func.is_core_func() and not vk_func.needs_private_thunk():
> -
>        if not vk_func.needs_private_thunk():
>            f.write("static ")
>
>        if vk_func.needs_private_thunk():

Hi Jacek,

is there a reason for not moving the f.write("static ") into the else 
block after this branch?

[Jacek Caban]

On 5/31/21 5:34 PM, Georg Lehmann wrote:
> On 31.05.21 16:17, Jacek Caban wrote:
> > Signed-off-by: Jacek Caban
> >
> > dlls/winevulkan/make_vulkan | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/dlls/winevulkan/make_vulkan b/dlls/winevulkan/make_vulkan
> > index 98a1e3ae2ac..14d0a04d341 100755
> > --- a/dlls/winevulkan/make_vulkan
> > +++ b/dlls/winevulkan/make_vulkan
> > @@ -2660,8 +2660,7 @@ class VkGenerator(object):
> >              if not vk_func.needs_thunk():
> >                  continue
> >
> > -            # Exports symbols for Core functions.
> > -            if not vk_func.is_core_func() and not 
> > vk_func.needs_private_thunk():
> > +            if not vk_func.needs_private_thunk():
> >                  f.write("static ")
> >
> > if vk_func.needs_private_thunk():
>
> Hi Jacek,
>
> is there a reason for not moving the f.write("static ") into the else 
> block after this branch?

It would be indeed better. I will send v2, thanks for review.

Jacek