Re: [v3 01/12] comctl32: Move TaskDialogIndirect and tests into own source files

[Nikolay Sivov]

On 10.03.2017 21:21, Fabian Maurer wrote:
> diff --git a/dlls/comctl32/taskdialog.c b/dlls/comctl32/taskdialog.c
> new file mode 100644
> index 0000000000..c26d53bac9
> --- /dev/null
> +++ b/dlls/comctl32/taskdialog.c
> @@ -0,0 +1,72 @@
> +/*
> -
> - Task dialog control
> -
> -
> -
> - Copyright 2017 Fabian Maurer for the Wine project
> -
> -
> -
> - This library is free software; you can redistribute it and/or
> -
> - modify it under the terms of the GNU Lesser General Public
> -
> - License as published by the Free Software Foundation; either
> -
> - version 2.1 of the License, or (at your option) any later version.
> -
> -
> -
> - This library is distributed in the hope that it will be useful,
> -
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> -
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -
> - Lesser General Public License for more details.
> -
> -
> -
> - You should have received a copy of the GNU Lesser General Public
> -
> - License along with this library; if not, write to the Free Software
> -
> - Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
> -
> -
> - */
> -
>
> +#include <stdarg.h>
> +#include <string.h>
> -
>
> +#include "windef.h"
> +#include "winbase.h"
> +#include "winuser.h"
> +#include "commctrl.h"
> +#include "winerror.h"
> +#include "comctl32.h"
> +#include "wine/debug.h"
> -
>
> +WINE_DEFAULT_DEBUG_CHANNEL(commctrl);
> -

Since it's move to its own file, let's call new debug channel "taskdlg"
for instance.

[v3 01/12] comctl32: Move TaskDialogIndirect and tests into own source files

[Fabian Maurer]

> Since it's move to its own file, let's call new debug channel "taskdlg"
> for instance.

Sure this is useful? Currently there aren't many debug logs anyways.
What's data that we should have in taskdialog debug logs?

Regards,
Fabian Maurer

[v3 01/12] comctl32: Move TaskDialogIndirect and tests into own source files

[Nikolay Sivov]

On 11.03.2017 1:07, Fabian Maurer wrote:
> > Since it's move to its own file, let's call new debug channel "taskdlg"
> > for instance.
>
> Sure this is useful? Currently there aren't many debug logs anyways.
> What's data that we should have in taskdialog debug logs?

Traces for exported functions, dialog proc trace, maybe a trace before
or after callback call.
> Regards,
> Fabian Maurer