Re: [1/3] WineD3D: An indirect address op can adjust min and max at the same time

[Henri Verbeet]

2009/7/7 Stefan Dösinger :
>                  if (reg->idx <= ((IWineD3DVertexShaderImpl *)This)->min_rel_offset)
> -
>                {
>                    ((IWineD3DVertexShaderImpl *)This)->min_rel_offset = reg->idx;
> -
>                else if (reg->idx >= ((IWineD3DVertexShaderImpl *)This)->max_rel_offset)
> -
>                }
> -
>                if (reg->idx >= ((IWineD3DVertexShaderImpl *)This)->max_rel_offset)
> -
>                {
>                    ((IWineD3DVertexShaderImpl *)This)->max_rel_offset = reg->idx;
> -
>                }

If you're going to fix it, you might as well fix it properly. There's
no point in assigning min_rel_offset or max_rel_offset if they're
already the same as reg->idx.

[1/3] WineD3D: An indirect address op can adjust min and max at the same time

[Stefan Dösinger]

Am Wednesday 08 July 2009 08:46:02 schrieb Henri Verbeet:
> If you're going to fix it, you might as well fix it properly. There's
> no point in assigning min_rel_offset or max_rel_offset if they're
> already the same as reg->idx.

Hmm true. Its a minor detail, but I send a new patch