------------------
武汉深之度科技有限公司 Wuhan Deepin Technology Co., Ltd.
谢威
手机:18038104349
武汉:武汉市光谷大道77号光谷金融港B18栋6楼 北京:北京市西城区新街口外大街28号院普天德胜B座603室 上海:上海市长宁区愚园路1258号15A01室
官网:www.deepin.org 官博:深度操作系统
On 05.01.2018 02:02, Wei Xie wrote:
res = pInternetGetSecurityInfoByURLA(url, NULL, NULL);
ok_(__FILE__,__LINE__)(!res, "InternetGetSecurityInfoByURLA failed: %u\n", GetLastError());
Please test GetLastError() in this case (I think that setting last error is missing in your second patch). Also it would be interesting to know if both arguments are required or one of them may be NULL. Please add a test that passes NULL for only one of them.
Also, if this test will crash without the second patch, the series should be reordered. All tests must pass between each separate commit. In this case I think that sending tests and a fix in one patch would be even better.
Thanks,
Jacek