Henri Verbeet hverbeet@codeweavers.com writes:
dlls/ddraw/tests/ddraw1.c | 217 +++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw2.c | 217 +++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw4.c | 216 ++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw7.c | 216 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 866 insertions(+), 0 deletions(-)
It doesn't work here:
../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so ddraw1.c && touch ddraw1.ok ddraw1.c:225: Test succeeded inside todo block: Got unexpected bounding rect {14, 33, 646, 486}, expected {14, 33, 646, 486}. ddraw1.c:231: Test succeeded inside todo block: Got unexpected clip rect {14, 33, 646, 486}, expected {14, 33, 646, 486}. make: *** [ddraw1.ok] Error 2
On 5 January 2012 18:19, Alexandre Julliard julliard@winehq.org wrote:
It doesn't work here:
../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so ddraw1.c && touch ddraw1.ok ddraw1.c:225: Test succeeded inside todo block: Got unexpected bounding rect {14, 33, 646, 486}, expected {14, 33, 646, 486}. ddraw1.c:231: Test succeeded inside todo block: Got unexpected clip rect {14, 33, 646, 486}, expected {14, 33, 646, 486}. make: *** [ddraw1.ok] Error 2
I guess that's because I ran it in a virtual desktop and the "GetDCEx(clipper->window, NULL, DCX_WINDOW);" call in ddraw_clipper_GetClipList() doesn't return quite the right area without it. Can we just remove the todo_wine's? I already have a patch to make it use the window's client rect.
Henri Verbeet hverbeet@gmail.com writes:
On 5 January 2012 18:19, Alexandre Julliard julliard@winehq.org wrote:
It doesn't work here:
../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so ddraw1.c && touch ddraw1.ok ddraw1.c:225: Test succeeded inside todo block: Got unexpected bounding rect {14, 33, 646, 486}, expected {14, 33, 646, 486}. ddraw1.c:231: Test succeeded inside todo block: Got unexpected clip rect {14, 33, 646, 486}, expected {14, 33, 646, 486}. make: *** [ddraw1.ok] Error 2
I guess that's because I ran it in a virtual desktop and the "GetDCEx(clipper->window, NULL, DCX_WINDOW);" call in ddraw_clipper_GetClipList() doesn't return quite the right area without it. Can we just remove the todo_wine's? I already have a patch to make it use the window's client rect.
If it always succeeds without a virtual desktop, then yes the todos can be removed.
On 5 January 2012 19:31, Alexandre Julliard julliard@winehq.org wrote:
If it always succeeds without a virtual desktop, then yes the todos can be removed.
Ok, please use the attached patch instead.
-
Alexandre Julliard -
Henri Verbeet