Dmitry Timoshkov wrote:
"Zachary Goldberg" <zgold550 at gmail.com> wrote:
Your patch is more likely to be accepted if it comes with a test which works on windows, didnt pass in wine before but passes now and demonstrates why the new behavior is correct.
There is no need for a test since that's not really an implementation but just a better stub which follows existing code.
So is there anything I should do now? Or just wait to see what happens?
As for writing a test, I don't think that's possible. The affected apps don't crash inside that function but shortly afterwards. It's just that the crash is affected by the result of RegisterDeviceNotificationW.
Wouldn't it also be more consistent, if *A and *W did the same thing?
Martin
So is there anything I should do now? Or just wait to see what happens?
Wait, as Alexandre's on vacation until the 18th. He'll probably commit this after he gets back, but if you notice a bunch of things getting committed and yours did not and did not get any feedback from him, you can ask again. --Juan
-
Juan Lang -
Martin Profittlich