Re: oleaut32: Add support for loading typelibs from NE files.

[Rob Shearman]

2008/9/2 Huw Davies :
> --- a/dlls/oleaut32/typelib.c
> +++ b/dlls/oleaut32/typelib.c
> @@ -64,6 +64,7 @@
>  #include "winnls.h"
>  #include "winreg.h"
>  #include "winuser.h"
> +#include "wine/winbase16.h"
>
> #include "wine/unicode.h"
>  #include "objbase.h"

I don't think we should be including a 16-bit header file and using
16-bit functions in a 32-bit source file if we can avoid it. In this
case, we can avoid it.

oleaut32: Add support for loading typelibs from NE files.

[Huw Davies]

On Wed, Sep 03, 2008 at 12:51:36PM +0100, Rob Shearman wrote:
> 2008/9/2 Huw Davies :
> > --- a/dlls/oleaut32/typelib.c
> > +++ b/dlls/oleaut32/typelib.c
> > @@ -64,6 +64,7 @@
> >  #include "winnls.h"
> >  #include "winreg.h"
> >  #include "winuser.h"
> > +#include "wine/winbase16.h"
> >
> > #include "wine/unicode.h"
> >  #include "objbase.h"
>
> I don't think we should be including a 16-bit header file and using
> 16-bit functions in a 32-bit source file if we can avoid it. In this
> case, we can avoid it.

Hi Rob,

How do you suggest we avoid it?

Cheers,
Huw.

oleaut32: Add support for loading typelibs from NE files.

[Rob Shearman]

2008/9/4 Huw Davies :
> On Wed, Sep 03, 2008 at 12:51:36PM +0100, Rob Shearman wrote:
> > 2008/9/2 Huw Davies :
> > > --- a/dlls/oleaut32/typelib.c
> > > +++ b/dlls/oleaut32/typelib.c
> > > @@ -64,6 +64,7 @@
> > >  #include "winnls.h"
> > >  #include "winreg.h"
> > >  #include "winuser.h"
> > > +#include "wine/winbase16.h"
> > >
> > > #include "wine/unicode.h"
> > >  #include "objbase.h"
> >
> > I don't think we should be including a 16-bit header file and using
> > 16-bit functions in a 32-bit source file if we can avoid it. In this
> > case, we can avoid it.
>
> How do you suggest we avoid it?

By parsing the file manually. There is code to do this already in
dlls/version/resource.c:find_ne_resource