Re: crypt32: implement CryptSIPLoad (try 5)

[Paul Vriens]

On 6/1/07, Juan Lang  wrote:
> Answering my own question, I see that the previous try introduced compiler
> warnings.  Fixed.
>
> ChangeLog: implement CryptSIPLoad
>
> --Juan

Hi Juan,

This patch still uses the non-native behavior. Is there a consensus on
this? I guess we are the only ones talking about this but I hope there
are more opinions.

I said before that I also don't know why native does it like that and
I don't see any benefit (yet). If this patch does get accepted we
should have a proper comment in the source (or are the comments in the
tests enough?).

Cheers,

Paul.

crypt32: implement CryptSIPLoad (try 5)

[Alexandre Julliard]

"Paul Vriens"  writes:
> This patch still uses the non-native behavior. Is there a consensus on
> this? I guess we are the only ones talking about this but I hope there
> are more opinions.
>
> I said before that I also don't know why native does it like that and
> I don't see any benefit (yet). If this patch does get accepted we
> should have a proper comment in the source (or are the comments in the
> tests enough?).

I think it's worth figuring out why native does it like this.

Also the dll loading part of the patch is quite confusing, hopefully
doing it closer to the native way would help make it clearer.