As Mike has said the patch is too long to review properly, so please break it down into much smaller pieces.
On Tue, Mar 07, 2006 at 04:29:04PM +0900, Byeong-Sik Jeon wrote:
and, I add some basic registry value. "Tahoma", "Gulim", "MS UI Gothic", "Simsun", "PMingLiU".
One thing that caught my eye was that these strings are locale dependent rather like the bitmap font strings (see update_font_info).
Keep up the good work!
Huw.
2006-03-07 (화), 10:45 +0000, Huw D M Davies 쓰시길:
As Mike has said the patch is too long to review properly, so please break it down into much smaller pieces.
Yes. now working...
and, I add some basic registry value. "Tahoma", "Gulim", "MS UI Gothic", "Simsun", "PMingLiU".
One thing that caught my eye was that these strings are locale dependent rather like the bitmap font strings (see update_font_info).
Yes. that is just thing like example, I will remove that.
but, tahoma is important. "Tahoma" is linked at the "System" and, many resource files use "MS Shell Dlg", and font substitutes "MS Shell Dlg"="Tahoma". therefore, if font(gulim.ttc, msgothic.ttc, ...) is exist, then we(CJK users) can see our latter at first start.
just only "tahoma"... HKLM: [Software\Microsoft\Windows NT\CurrentVersion\FontLink\SystemLink] "Tahoma"=str(7):"Gulim.ttc,Gulim\0MsGothic.ttc,MS UI Gothic \0SimSun.ttc,SimSun\0Mingliu.ttc,PMingLiU\0"
On Tue, Mar 07, 2006 at 08:22:36PM +0900, Byeong-Sik Jeon wrote:
2006-03-07 (화), 10:45 +0000, Huw D M Davies 쓰시길:
As Mike has said the patch is too long to review properly, so please break it down into much smaller pieces.
Yes. now working...
Great.
One thing that caught my eye was that these strings are locale dependent rather like the bitmap font strings (see update_font_info).
Yes. that is just thing like example, I will remove that.
but, tahoma is important. "Tahoma" is linked at the "System" and, many resource files use "MS Shell Dlg", and font substitutes "MS Shell Dlg"="Tahoma". therefore, if font(gulim.ttc, msgothic.ttc, ...) is exist, then we(CJK users) can see our latter at first start.
just only "tahoma"... HKLM: [Software\Microsoft\Windows NT\CurrentVersion\FontLink\SystemLink] "Tahoma"=str(7):"Gulim.ttc,Gulim\0MsGothic.ttc,MS UI Gothic \0SimSun.ttc,SimSun\0Mingliu.ttc,PMingLiU\0"
Right, but even Tahoma is locale dependent - the order of Gulim, MS UI Gothic etc changes.
Huw.
2006-03-07 (화), 11:33 +0000, Huw D M Davies 쓰시길:
Right, but even Tahoma is locale dependent - the order of Gulim, MS UI Gothic etc changes.
Yes. but lucky thing... fsCsb[0] information of each font are:
Gulim : ANSI, EASTEUROPE, RUSSIAN, GREEK, TURKISH, BALTIC, "HANGEUL" MS UI Gothic: ANSI, ASTEUROPE, RUSSIAN, GREEK, TURKISH, BALTIC, "SHIFTJIS" MingLiU : ANSI, "CHINESEBIG5" SimSun : ANSI, "GB2312"
therefore, at japanese locale, if call "tahoma" then use "msgothic.ttc" (not "gulim.ttc").
But, I think that this is "FIXME" feature.
2006-03-07 (화), 10:45 +0000, Huw D M Davies 쓰시길:
As Mike has said the patch is too long to review properly, so please break it down into much smaller pieces.
On Tue, Mar 07, 2006 at 04:29:04PM +0900, Byeong-Sik Jeon wrote:
and, I add some basic registry value. "Tahoma", "Gulim", "MS UI Gothic", "Simsun", "PMingLiU".
One thing that caught my eye was that these strings are locale dependent rather like the bitmap font strings (see update_font_info).
Sorry, Huw.
I understand. update_font_info() have to create the [HKLM\Software\Microsoft\ \Windows NT\CurrentVersion\FontLink\SystemLink] and add Tahoma, etc value. it's more more better good approach.
I'll remove add_reg_value_system_font_link().
-
Byeong-Sik Jeon -
Huw D M Davies