Alexandre Julliard wrote:
penna@bb.com.br writes:
There is a patch proposed at the bug #7571 (http://bugs.winehq.org/show_bug.cgi?id=7571). It works very well and I did not experiment any regression. Maybeit is not the ideal patch and if it is not, maybe we can provide a fix for that. However, at least it fixes the font problem and did not introduce any undesirable efects. Is that possible to apply that patch at the main tree? Comments are also welcome!
You should provide test cases that show that your patch is correct.
I used Dmitry's tests [1] for this patch.
[1] http://www.winehq.org/pipermail/wine-patches/2007-March/036706.html
Shouldn't that be enough, I'll look into it again.
- Pedro.
-- "Caritas omnia vincit."
"Abel Chiaro" inckie@gmail.com writes:
Alexandre Julliard wrote:
You should provide test cases that show that your patch is correct.
I used Dmitry's tests [1] for this patch.
[1] http://www.winehq.org/pipermail/wine-patches/2007-March/036706.html
Shouldn't that be enough, I'll look into it again.
So does that test behave differently for you with your patch? Does it show that things are fixed? Which font are you testing with?
Alexandre Julliard julliard@winehq.org wrote:
So does that test behave differently for you with your patch? Does it show that things are fixed? Which font are you testing with?
The patch adds a missing else to the codepage tests in WineEngEnumFonts(), making it handle DEFAULT_CHARSET rather than ignore it.
As I pointed out in comment #49 to bug #7571 [1], this eventually revealed that either (a) there's a bug in our font loading functions, or (b) some fonts have some reserved bits set, which strikes me as odd.
I have tested the patch with quite a few fonts, including (but not limited to) Apple Garamond, Apple Garamond Light, Arial, Arial Black, Arrus BT, Arrus Blk BT, Calibri, Cambria, Candara, Consolas, Constantia, Corbel, Courier New, Segoe, Segoe Black, Segoe Light, Segoe Condensed, Segoe Print, Segoe UI, Times New Roman, and Trebuchet MS.
At least with those fonts (since I can't test every single font out there), the patch fixes the issue. And it passes Dmitry's tests.
"Abel Chiaro" inckie@gmail.com writes:
At least with those fonts (since I can't test every single font out there), the patch fixes the issue. And it passes Dmitry's tests.
The problem is that looking at differences in the traces is not a good test, since it can't be automated. What is really needed is a test case that succeeds on Windows, fails on current Wine, and succeeds on Wine + your patch. That's also the only way to make sure that the bug doesn't reappear.
-
Abel Chiaro -
Alexandre Julliard