if anybody wishes to tackle a fun bug, take a look at the imagelist control in commctrl32 - it corrupts masks, giving some nasty visual corruption esp on toolbar icons, but i've also seen it in winrar.
i suspect the _read_bitmap function doesn't do 1bit images correctly, but didn't really manage to find out. i might have another crack tomorrow, but in case somebody is looking for a job.... :)
On Sun, Mar 16, 2003 at 02:02:18AM +0000, Mike Hearn wrote:
if anybody wishes to tackle a fun bug, take a look at the imagelist control in commctrl32 - it corrupts masks, giving some nasty visual corruption esp on toolbar icons, but i've also seen it in winrar.
Have a look at this email http://www.winehq.com/hypermail/wine-patches/2003/03/0038.html ImageList_AddMasked() is known to corrupt images.
bye michael
i suspect the _read_bitmap function doesn't do 1bit images correctly, but didn't really manage to find out. i might have another crack tomorrow, but in case somebody is looking for a job.... :)
I think this is different - I have that patch applied, and it still corrupts things. Also AddMasked isn't used in this app iirc.
On Sun, 2003-03-16 at 15:59, Michael Stefaniuc wrote:
On Sun, Mar 16, 2003 at 02:02:18AM +0000, Mike Hearn wrote:
if anybody wishes to tackle a fun bug, take a look at the imagelist control in commctrl32 - it corrupts masks, giving some nasty visual corruption esp on toolbar icons, but i've also seen it in winrar.
Have a look at this email http://www.winehq.com/hypermail/wine-patches/2003/03/0038.html ImageList_AddMasked() is known to corrupt images.
bye michael
i suspect the _read_bitmap function doesn't do 1bit images correctly, but didn't really manage to find out. i might have another crack tomorrow, but in case somebody is looking for a job.... :)
On Sun, Mar 16, 2003 at 04:19:55PM +0000, Mike Hearn wrote:
I think this is different - I have that patch applied, and it still corrupts things. Also AddMasked isn't used in this app iirc.
Is the app using ImageList_LoadImage{A,W}()? Both functions are using AddMasked without copying the bitmap. Same applies for TREEVIEW_Create()
bye michael
On Sun, 2003-03-16 at 15:59, Michael Stefaniuc wrote:
On Sun, Mar 16, 2003 at 02:02:18AM +0000, Mike Hearn wrote:
if anybody wishes to tackle a fun bug, take a look at the imagelist control in commctrl32 - it corrupts masks, giving some nasty visual corruption esp on toolbar icons, but i've also seen it in winrar.
Have a look at this email http://www.winehq.com/hypermail/wine-patches/2003/03/0038.html ImageList_AddMasked() is known to corrupt images.
bye michael
i suspect the _read_bitmap function doesn't do 1bit images correctly, but didn't really manage to find out. i might have another crack tomorrow, but in case somebody is looking for a job.... :)
Is the app using ImageList_LoadImage{A,W}()? Both functions are using AddMasked without copying the bitmap. Same applies for TREEVIEW_Create()
bye michael
nope, not using AddMasked at all, I checked the traces and commented out the code to simulate the windows bug etc, no change.
It loads the image/mask in using Read which pulls it in from a stream
Here's a screenshot of the type of corruption:
-
Michael Stefaniuc -
Mike Hearn