build error in dlls/d3dx9_36/tests/math.c

[Marcus Meissner]

Hi,

I get on dlls/d3dx9_36/tests/math.c:

(Code added in a6b40624dbc457ba7b0b4b307b1eb88617c67197 by Misha Koshelev )
gcc -c -I. -I. -I../../../include -I../../../include  -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION  -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-stateme
nt -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith  -DLDAP_DEPRECATED=1 -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-prot
ector -funwind-tables -fasynchronous-unwind-tables -g -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0  -o mesh.o mesh.c
math.c: In function 'test_D3DXFloat_Array':
math.c:2251: error: 'INFINITY' undeclared (first use in this function)
math.c:2251: error: (Each undeclared identifier is reported only once
math.c:2251: error: for each function it appears in.)
math.c:2253: error: 'NAN' undeclared (first use in this function)
make[1]: *** [math.o] Error 1

NAN and INFINITY variables are ISO C 99 features and would need
#define _ISOC99_SOURCE
at the beginning of the source.

Would such a patch be accepted? Or perhaps add 0.0/0.0 1.0/0.0 or similar constructs?

Ciao, Marcus

-----
"Marcus Meissner"
> Hi,
>
> I get on dlls/d3dx9_36/tests/math.c:

Hi, and i got some test failures on my 64bit test machines:

http://test.winehq.org/data/a3965c7ea017480a21ec934753bf4135c571a9d9/xp_Wyld...

W.

[Nikolay Sivov]

On Sat, Jul 9, 2011 at 12:56 PM, Marcus Meissner  wrote:
> Hi,
>
> I get on dlls/d3dx9_36/tests/math.c:

There is a report about that even
http://bugs.winehq.org/show_bug.cgi?id=27676 . Just for a reference.

[Frédéric Delanoy]

On Sat, Jul 9, 2011 at 10:56, Marcus Meissner  wrote:
> Hi,
>
> I get on dlls/d3dx9_36/tests/math.c:
>
> (Code added in a6b40624dbc457ba7b0b4b307b1eb88617c67197 by Misha Koshelev )
> gcc -c -I. -I. -I../../../include -I../../../include  -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION  -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-stateme
> nt -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith  -DLDAP_DEPRECATED=1 -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-prot
> ector -funwind-tables -fasynchronous-unwind-tables -g -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0  -o mesh.o mesh.c
> math.c: In function 'test_D3DXFloat_Array':
> math.c:2251: error: 'INFINITY' undeclared (first use in this function)
> math.c:2251: error: (Each undeclared identifier is reported only once
> math.c:2251: error: for each function it appears in.)
> math.c:2253: error: 'NAN' undeclared (first use in this function)
> make[1]: *** [math.o] Error 1
>
> NAN and INFINITY variables are ISO C 99 features and would need
> #define _ISOC99_SOURCE
> at the beginning of the source.
>
> Would such a patch be accepted? Or perhaps add 0.0/0.0 1.0/0.0 or similar constructs?
>
> Ciao, Marcus

C99 constructs will probably be refused for portability reasons.
E.g. see http://www.mail-archive.com/[e-mail]/msg70155.html

Frédéric