Re: [PATCH 3/4] msvcp90: Define basic_string for runtime_error when not msvcirt.

[Piotr Caban]

Hi Daniel,

why do you need it? The class should be not used/exported in msvcirt.

Thanks,
Piotr

[PATCH 3/4] msvcp90: Define basic_string for runtime_error when not msvcirt.

[Daniel Lehman]

> why do you need it? The class should be not used/exported in msvcirt.

Ah, I don't need it.  the existing runtime_error functions are individually #ifndef _MSVCIRT like the rest that are exported by msvcirt, and I admittedly hadn't noticed that it wasn't exported by msvcirt.  Could the whole runtime_error just be #ifndef _MSVCIRT?

Thanks
daniel

[PATCH 3/4] msvcp90: Define basic_string for runtime_error when not msvcirt.

[Piotr Caban]

On 10/13/17 16:13, Daniel Lehman wrote:
> > why do you need it? The class should be not used/exported in msvcirt.
>
> Ah, I don't need it.  the existing runtime_error functions are individually #ifndef _MSVCIRT like the rest that are exported by msvcirt, and I admittedly hadn't noticed that it wasn't exported by msvcirt.  Could the whole runtime_error just be #ifndef _MSVCIRT?

Yes, it can be put inside ifndef block.

Thanks,
Piotr

[PATCH 3/4] msvcp90: Define basic_string for runtime_error when not msvcirt.

[Daniel Lehman]

> > Ah, I don't need it.  the existing runtime_error functions are individually #ifndef _MSVCIRT like the rest that are exported by msvcirt, and I admittedly hadn't noticed that it wasn't exported by msvcirt.  Could the whole runtime_error just be #ifndef _MSVCIRT?
>
> Yes, it can be put inside ifndef block.

the rest of the series ok?  they don't depend on it

thanks
daniel

[PATCH 3/4] msvcp90: Define basic_string for runtime_error when not msvcirt.

[Piotr Caban]

On 10/13/17 16:32, Daniel Lehman wrote:
> > > Ah, I don't need it.  the existing runtime_error functions are individually #ifndef _MSVCIRT like the rest that are exported by msvcirt, and I admittedly hadn't noticed that it wasn't exported by msvcirt.  Could the whole runtime_error just be #ifndef _MSVCIRT?
> >
> > Yes, it can be put inside ifndef block.
>
> the rest of the series ok?  they don't depend on it

Patch 4 looks good to me, I'm currently writing some tests for patch 2 
(so I'm not sure yet, but it looks suspicious).

Thanks,
Piotr