[PATCH] po: Updated Dutch translation.

[floris]

Updated Dutch translation

---
Floris

[Floris Renaud]

floris schreef op 2021-01-22 18:58:
> Updated Dutch translation
>
> Floris

I found more errors, too long lines and strange translations in the 
original dutch translation.
The previous diff isn't applied yet. Should I post a new diff file 
relative to the original file or the new one?

[Julian Rüger]

Hi Floris!

First of all, thanks for your work!

I spotted a few formal issues with your patch:

* please make sure to use git format-patch, not just plain diff
 (see https://wiki.winehq.org/Submitting_Patches )
* you need to add a signed-off-by line to your mail
( something like "Signed-off-by: Julian Rüger " with your
own name of course ;)
* may seem like a stupid nitpick, but consistency and details are
important to the Wine project; we use the imperative form for patch
subjects, i.e. "po: Update Dutch translation." instead of "updated"
> I found more errors, too long lines and strange translations in the
> original dutch translation.
> The previous diff isn't applied yet. Should I post a new diff file
> relative to the original file or the new one?

Since you'll have to resend the first patch anyway, you could merge
them, but smaller patches are easier to review and generally preferred.
You can send them as a series, with the later patches applied on top of
the previous ones and use a tag for your email subject line "[PATCH 1/2]
po: Update..." (not the commit message).

It would probably make sense to split the first patch into multiple ones
as well, though the rules are less strict for translations.

See the mailing list archives for examples how other devs do it.
https://www.winehq.org/pipermail/wine-devel/

Best,
Julian

[Julian Rüger]

Also, please make sure you only change the actual translations (the
msgstrs), not the msgids or comments like you do here:
> #: dlls/appwiz.cpl/appwiz.rc:61
> msgid ""
> -"To install a new program from a floppy disk, CD-ROM drive, or your hard "
> -"drive, click Install."
> +"To install a new program from a floppy disk, CD-ROM drive, or your hard drive, "
> +"click Install."

and here:
> @@ -70,29 +71,29 @@
> #: dlls/ieframe/ieframe.rc:96 dlls/localui/localui.rc:44
> #: dlls/localui/localui.rc:57 dlls/mpr/mpr.rc:49 dlls/msacm32/msacm32.rc:53
> #: dlls/mshtml/mshtml.rc:47 dlls/mshtml/mshtml.rc:57 dlls/msvfw32/msvfw32.rc:36
> -#: dlls/oledlg/oledlg.rc:62 dlls/oledlg/oledlg.rc:94
> -#: dlls/serialui/serialui.rc:41 dlls/setupapi/setupapi.rc:59
> -#: dlls/shell32/shell32.rc:276 dlls/shell32/shell32.rc:300
> -#: dlls/shell32/shell32.rc:322 dlls/shell32/shell32.rc:341
> -#: dlls/shlwapi/shlwapi.rc:44 dlls/twain_32/twain.rc:32
> -#: dlls/user32/user32.rc:83 dlls/user32/user32.rc:98 dlls/wininet/wininet.rc:62
> [...]

The only things you *should* change that are not msgstr are "# fuzzy" lines, like this:

#: dlls/kernel32/winerror.mc:3788
-#, fuzzy
-#| msgid "RPC call failed.\n"
 msgid "Call failed.\n"
-msgstr "RPC-Aufruf fehlgeschlagen.\n"
+msgstr "Aufruf fehlgeschlagen.\n"

Hope that helps!

Julian