Re: [3/5] wined3d: Use SetupFullscreenWindow() to make the window fullscreen

[Stefan Dösinger]

Am Donnerstag 18 Januar 2007 23:41 schrieb H. Verbeet:
> Changelog:
> - Use SetupFullscreenWindow() to make the window fullscreen

I do not think that SetupFullscreenWindow should stay publically exported from 
wined3d. I think it would be better if IWineD3DDevice_SetFullscreen calls it, 
and it is made sure that SetFullscreen is called when needed with a true / 
false flag. DDraw calls it already, and I think Init3D() calls it too for 
d3d8 and d3d9. Not sure about IWineD3DDevice_Reset.

[3/5] wined3d: Use SetupFullscreenWindow() to make the window fullscreen

[H. Verbeet]

On 19/01/07, Stefan Dösinger  wrote:
> Am Donnerstag 18 Januar 2007 23:41 schrieb H. Verbeet:
> > Changelog:
> > - Use SetupFullscreenWindow() to make the window fullscreen
>
> I do not think that SetupFullscreenWindow should stay publically exported from
> wined3d. I think it would be better if IWineD3DDevice_SetFullscreen calls it,
> and it is made sure that SetFullscreen is called when needed with a true /
> false flag. DDraw calls it already, and I think Init3D() calls it too for
> d3d8 and d3d9. Not sure about IWineD3DDevice_Reset.

Probably not, no. DDraw should probably call it through SetFullscreen
instead. AFAIK d3d8 / d3d9 don't call SetFullscreen. Currently
SetupFullscreenWindow is called from CreateAdditionalSwapChain, but
perhaps that should call SetFullscreen then.