Re: [PATCH 3/5] wined3d: make wined3d_swapchain_get_front_buffer_data work with wined3d_texture and sub_resource_idx

[Henri Verbeet]

On 15 October 2015 at 15:41, Riccardo Bortolato  wrote:
> - if (!(sub_resource = wined3d_texture_get_sub_resource(dst_texture, sub_resource_idx)) ||
> -
>        sub_resource->type != WINED3D_RTYPE_SURFACE)

Not a big issue, but if you're resending the series anyway, we usually
put the "||" on the next line. (Here and in patch 4/5.)

[PATCH 3/5] wined3d: make wined3d_swapchain_get_front_buffer_data work with wined3d_texture and sub_resource_idx

[Riccardo Bortolato]

Fixed, and rebased 4/5 on top of:

wined3d: The cursor image surface is not allowed to be NULL in
wined3d_device_set_cursor_properties().

Ciao,
Riccardo

2015-10-16 12:43 GMT+02:00 Henri Verbeet :
> On 15 October 2015 at 15:41, Riccardo Bortolato  wrote:
> > - if (!(sub_resource = wined3d_texture_get_sub_resource(dst_texture, sub_resource_idx)) ||
> > -
> >        sub_resource->type != WINED3D_RTYPE_SURFACE)
>
> Not a big issue, but if you're resending the series anyway, we usually
> put the "||" on the next line. (Here and in patch 4/5.)