Re: gdi32 test

[Dmitry Timoshkov]

"Stefan Leichter"  wrote:
> ChangeLog
>
> add a test for CreateDCW

1. there is no need to import CreateDCW dynamically, it always exists
2. dlls/user/tests/monitor.c,test_enumdisplaydevices() test already
does this, so your test is redundant.

gdi32 test

[Stefan Leichter]

Am Donnerstag, 5. Januar 2006 06:36 schrieb Dmitry Timoshkov:
> "Stefan Leichter"  wrote:
> > ChangeLog
> >
> > add a test for CreateDCW
> - there is no need to import CreateDCW dynamically, it always exists
> - dlls/user/tests/monitor.c,test_enumdisplaydevices() test already
>
> does this, so your test is redundant.

Does test_enumdisplaydevices() return any todo:s to you on wine? Not for me. 
The new tests returns a todo, so why do you think it is redundant?

You can call the new test a reminder what is still missing in wine

--
Bye Stefan

gdi32 test

[Dmitry Timoshkov]

"Stefan Leichter"  wrote:
> Does test_enumdisplaydevices() return any todo:s to you on wine? Not for me. 
> The new tests returns a todo, so why do you think it is redundant?

In which way new test fails for you? GDI should be able to handle "\.\DISPLAY1"
in CreateDC these days.
> You can call the new test a reminder what is still missing in wine

Sure, once you fix it to pass on Win9x as well as remove calling CreateDCW
via a pointer.

gdi32 test

[Vitaliy Margolen]

Thursday, January 5, 2006, 2:15:21 AM, Stefan Leichter wrote:
> Am Donnerstag, 5. Januar 2006 06:36 schrieb Dmitry Timoshkov:
> > "Stefan Leichter"  wrote:
> > > ChangeLog
> > >
> > > add a test for CreateDCW
> > - there is no need to import CreateDCW dynamically, it always exists
> > - dlls/user/tests/monitor.c,test_enumdisplaydevices() test already
> >
> > does this, so your test is redundant.
> Does test_enumdisplaydevices() return any todo:s to you on wine? Not for me.
> The new tests returns a todo, so why do you think it is redundant?
> You can call the new test a reminder what is still missing in wine

It is already fixed. And I added a patch to test that as well. It's a bit
different then yours.

Vitaliy.