Hi Henri, thanks for reviewing.
/* 6: Test maximum surface height */{DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT,DDSCAPS_OFFSCREENPLAIN, 1, 0x10000, DDERR_INVALIDPARAMS},
/* 7: Test maximum surface width */{DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT,DDSCAPS_OFFSCREENPLAIN, 0x10000, 1, DDERR_INVALIDPARAMS},
It would perhaps also be useful to verify that e.g. a 1 by 0xffff surface actually is allowed.
I've not included the tests for DirectDraw surfaces with dimension 1 by 0xffff and 0xffff by 1 as they fail on wine. The surfaces are provided by Opengl textures and the maximum texture size is less than 0xffff. However on Windows these tests pass, if the graphic cards pitch is great enough. Stefan pointed out that on old cards this test might fail. Should I add a separate test for this including a wine_todo ? I guess this won't be fixed any time soon...
Regards, Patrick
On 15 July 2014 10:20, Patrick Rudolph siro@das-labor.org wrote:
I've not included the tests for DirectDraw surfaces with dimension 1 by 0xffff and 0xffff by 1 as they fail on wine. The surfaces are provided by Opengl textures and the maximum texture size is less than 0xffff. However on Windows these tests pass, if the graphic cards pitch is great enough. Stefan pointed out that on old cards this test might fail. Should I add a separate test for this including a wine_todo ? I guess this won't be fixed any time soon...
Marking it as todo_wine should be fine, although I wonder if you'll actually get a video memory surface that way, or only a system memory surface.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2014-07-15 10:20, schrieb Patrick Rudolph:
Stefan pointed out that on old cards this test might fail.
If I remember correctly the problem was that some cards have a pitch limit of something slightly smaller than 2^17. So a width = 0xffff surface fails on some cards unless the format is a 8 bpp format. Testing a height = 0xffff surface should be fine though.
-
Henri Verbeet -
Patrick Rudolph -
Stefan Dösinger