Re: advpack: Use GetModuleHandle instead of LoadLibrary.

[Paul Vriens]

On 01/05/2010 02:46 AM, James Hawkins wrote:
> dlls/advpack/tests/advpack.c |    7 +------
>   1 files changed, 1 insertions(+), 6 deletions(-)

Hi James,

Don't think this works:

advpack: 0 tests executed (0 marked as todo, 0 failures), 0 skipped.

advpack: Use GetModuleHandle instead of LoadLibrary.

[Paul Vriens]

On 01/05/2010 11:50 AM, Paul Vriens wrote:
> On 01/05/2010 02:46 AM, James Hawkins wrote:
> > dlls/advpack/tests/advpack.c | 7 +------
> > 1 files changed, 1 insertions(+), 6 deletions(-)
>
> Hi James,
>
> Don't think this works:
>
> advpack: 0 tests executed (0 marked as todo, 0 failures), 0 skipped.

Hi James,

I guess this change was meant to silence Valgrind?

I see several Valgrind reports that all have to do with the loading of 
advpack.dll (all the advpack test ones and shell32:progman_dde test). I 
haven't found the reason yet, nor was I able to trigger the Valgrind 
error in the first place btw.

advpack: Use GetModuleHandle instead of LoadLibrary.

[James Hawkins]

On Sun, Jan 10, 2010 at 12:57 PM, Paul Vriens
 wrote:
> On 01/05/2010 11:50 AM, Paul Vriens wrote:
> > On 01/05/2010 02:46 AM, James Hawkins wrote:
> > > dlls/advpack/tests/advpack.c | 7 +------
> > > 1 files changed, 1 insertions(+), 6 deletions(-)
> >
> > Hi James,
> >
> > Don't think this works:
> >
> > advpack: 0 tests executed (0 marked as todo, 0 failures), 0 skipped.
>
> Hi James,
>
> I guess this change was meant to silence Valgrind?
>
> I see several Valgrind reports that all have to do with the loading of
> advpack.dll (all the advpack test ones and shell32:progman_dde test). I
> haven't found the reason yet, nor was I able to trigger the Valgrind error
> in the first place btw.

Yes, that was my intent.  I'm stumped by the leaks.