Re: [PATCH 4/5] d3d11/tests: Add test for writing special floating-point values to render target.

[Henri Verbeet]

On 13 July 2016 at 10:52, Józef Kucia  wrote:
> +#ifndef NAN
> +static inline float __port_nan(void)
> +{
> - static const unsigned __nan_bytes = 0x7fc00000;
> - return *(const float *)&__nan_bytes;
>
> +}
> +#define NAN __port_nan()
> +#endif

This looks unused.
> -
>        const struct vec4 *value = get_readback_vec4(&rb, x, y);
> -
>        ok(isnan(value->x) && value->y == INFINITY && value->z == -INFINITY && value->w == 1.0f,
> -
>                "Got unexpected value {%.8e, %.8e, %.8e, %.8e} at (%u, %u).\n",
> -
>                value->x, value->y, value->z, value->w, x, y);

It would slightly change the meaning of the test, but you could also
just read these back as uvec4's and compare the bit patterns.
> @@ -9312,4 +9400,5 @@ START_TEST(d3d11)
>      test_check_feature_support();
>      test_create_unordered_access_view();
>      test_immediate_constant_buffer();
> - test_special_float_values();

For what it's worth, those are usually called "floating-point
specials". (And hence fp_special_test() in the d3d9 tests.)