re: clusapi.h - add states for GetNodeClusterState()

[Dan Kegel]

You might have more luck getting these three patches
in if you also checked in a conformance test that depended on them.

And were you careful to write winsxs.h yourself as opposed to
copying and pasting from a Microsoft header or web page?
- Dan

clusapi.h - add states for GetNodeClusterState()

[EA Durbin]

> From: "Dan Kegel" 
> To: "[e-mail]" 
> CC: "EA Durbin" 
> Subject: re: clusapi.h - add states for GetNodeClusterState()
> Date: Thu, 19 Apr 2007 10:18:19 -0700
>
> You might have more luck getting these three patches
> in if you also checked in a conformance test that depended on them.
>
> And were you careful to write winsxs.h yourself as opposed to
> copying and pasting from a Microsoft header or web page?
> - Dan

yes, I typed it myself

_________________________________________________________________
Interest Rates NEAR 39yr LOWS!  $430,000 Mortgage for $1,299/mo - Calculate 
new payment 
http://www.lowermybills.com/lre/index.jsp?sourceid=lmb-9632-19132&moid=1...

clusapi.h - add states for GetNodeClusterState()

[EA Durbin]

> From: "Dan Kegel" 
> To: "[e-mail]" 
> CC: "EA Durbin" 
> Subject: re: clusapi.h - add states for GetNodeClusterState()
> Date: Thu, 19 Apr 2007 10:18:19 -0700
>
> You might have more luck getting these three patches
> in if you also checked in a conformance test that depended on them.
>
> And were you careful to write winsxs.h yourself as opposed to
> copying and pasting from a Microsoft header or web page?
> - Dan

The .dll is a stub dll, according to the wiki developer hints page it has to 
be added first with only DLLMain before I can start adding any functions, or 
conformance tests.

_________________________________________________________________
Exercise your brain! Try Flexicon. 
http://games.msn.com/en/flexicon/default.htm?icid=flexicon_hmemailtaglineapr...

clusapi.h - add states for GetNodeClusterState()

[Dan Kegel]

On 4/19/07, EA Durbin  wrote:
> > You might have more luck getting these three patches
> > in if you also checked in a conformance test that depended on them.
>
> The .dll is a stub dll, according to the wiki developer hints page it has to
> be added first with only DLLMain before I can start adding any functions, or
> conformance tests.

You're right:
http://wiki.winehq.org/Developers-Hints#head-30a7f7f51ce0e42b4141749c9832bae...
but that only excuses one of your patches.

The first patch that just creates the stub dll is ok,
but the second patch (the one that adds all the structs constants in
the .h file)
should have included an implementation and conformance test
that exercized those constants and structures.
- Dan