OSS Bug

[Rod Taylor]

http://bugs.winehq.com/long_list.cgi?buglist=1349

I think bug 1349 is related to the below conversation.

http://www.winehq.com/hypermail/wine-devel/2003/03/0379.html

Robert Reif suggested I send in a note.

[Robert Reif]

The problem Rod is seeing is caused by code that I added to
check the return value of an ioctl in OSS_RawOpenDevice.
The code now checks the return value and returns on failure
rather than ignoring it.  I don't know if this is a BSD issue or
a hardware driver issue or something else.

Rod Taylor wrote:
> http://bugs.winehq.com/long_list.cgi?buglist=1349
>
> I think bug 1349 is related to the below conversation.
>
> http://www.winehq.com/hypermail/wine-devel/2003/03/0379.html
>
> Robert Reif suggested I send in a note.
>
> --
> Rod Taylor
>
> PGP Key: http://www.rbt.ca/rbtpub.asc
>                    Name: signature.asc
>
> signature.asc       Type: application/x-unknown-content-type-asc_auto_file
>                 Description: This is a digitally signed message part

[Rod Taylor]

Found something related:

http://news.gw.com/freebsd.bugs/22626

According to it, FreeBSD doesn't have that ioctl as it's always on.

On Tue, 2003-04-01 at 19:09, Robert Reif wrote:
> The problem Rod is seeing is caused by code that I added to
> check the return value of an ioctl in OSS_RawOpenDevice.
> The code now checks the return value and returns on failure
> rather than ignoring it.  I don't know if this is a BSD issue or
> a hardware driver issue or something else.
>
> Rod Taylor wrote:
> > http://bugs.winehq.com/long_list.cgi?buglist=1349
> >
> > I think bug 1349 is related to the below conversation.
> >
> > http://www.winehq.com/hypermail/wine-devel/2003/03/0379.html
> >
> > Robert Reif suggested I send in a note.
> >
> > --
> > Rod Taylor
> >
> > PGP Key: http://www.rbt.ca/rbtpub.asc
> >                    Name: signature.asc
> >
> > signature.asc       Type: application/x-unknown-content-type-asc_auto_file
> >                 Description: This is a digitally signed message part

[Eric Pouech]

Rod Taylor wrote:
> Found something related:
>
> http://news.gw.com/freebsd.bugs/22626
>
> According to it, FreeBSD doesn't have that ioctl as it's always on.

what errno value do you get when the call fails ?
I'd suggest we ignore the error if ioctl returns -1 with this specific 
errno (if possible)

A+

[Rod Taylor]

By default it seems to return EINVAL.

Line 953
http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/sound/pcm/dsp.c?annotate=1...

On Wed, 2003-04-02 at 13:20, Eric Pouech wrote:
> Rod Taylor wrote:
> > Found something related:
> >
> > http://news.gw.com/freebsd.bugs/22626
> >
> > According to it, FreeBSD doesn't have that ioctl as it's always on.
>
> what errno value do you get when the call fails ?
> I'd suggest we ignore the error if ioctl returns -1 with this specific 
> errno (if possible)
>
> A+

[Eric Pouech]

Rod Taylor wrote:
> By default it seems to return EINVAL.
>
> Line 953
> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/sound/pcm/dsp.c?annotate=1...

so something like this should do.

A+

[Rod Taylor]

Sound works again with this patch.

On Thu, 2003-04-03 at 14:48, Eric Pouech wrote:
> Rod Taylor wrote:
> > By default it seems to return EINVAL.
> >
> > Line 953
> > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/sound/pcm/dsp.c?annotate=1...
>
> so something like this should do.
>
> A+