Re: [PATCH 3/4] ole32: Add a stub for OleCreateFromFileEx.

[Dmitry Timoshkov]

Huw Davies  wrote:
> --- a/dlls/ole32/ole32.spec
> +++ b/dlls/ole32/ole32.spec
> @@ -189,7 +189,7 @@
>  @ stdcall OleCreateFromData(ptr ptr long ptr ptr ptr ptr)
>  @ stdcall OleCreateFromDataEx(ptr ptr long long long ptr ptr ptr ptr ptr ptr ptr)
>  @ stdcall OleCreateFromFile(ptr ptr ptr long ptr ptr ptr ptr)
> -@ stub OleCreateFromFileEx
> +@ stdcall OleCreateFromFileEx(ptr ptr ptr long long long ptr ptr ptr ptr ptr ptr ptr)

The 2nd parameter should be str, but that's not your fault, probably
you've just copied and extended the OleCreateFromFile entry :)

[PATCH 3/4] ole32: Add a stub for OleCreateFromFileEx.

[Huw Davies]

On 9 Oct 2015, at 10:42, Dmitry Timoshkov wrote:
> Huw Davies  wrote:
> > --- a/dlls/ole32/ole32.spec
> > +++ b/dlls/ole32/ole32.spec
> > @@ -189,7 +189,7 @@
> > @ stdcall OleCreateFromData(ptr ptr long ptr ptr ptr ptr)
> > @ stdcall OleCreateFromDataEx(ptr ptr long long long ptr ptr ptr ptr ptr ptr ptr)
> > @ stdcall OleCreateFromFile(ptr ptr ptr long ptr ptr ptr ptr)
> > -@ stub OleCreateFromFileEx
> > +@ stdcall OleCreateFromFileEx(ptr ptr ptr long long long ptr ptr ptr ptr ptr ptr ptr)
>
> The 2nd parameter should be str, but that's not your fault, probably
> you've just copied and extended the OleCreateFromFile entry :)

Thanks, I did exactly that. Resent.

Huw.

[PATCH 3/4] ole32: Add a stub for OleCreateFromFileEx.

[Huw Davies]

On 9 Oct 2015, at 10:50, Huw Davies wrote:
> On 9 Oct 2015, at 10:42, Dmitry Timoshkov wrote:
> > Huw Davies  wrote:
> > > --- a/dlls/ole32/ole32.spec
> > > +++ b/dlls/ole32/ole32.spec
> > > @@ -189,7 +189,7 @@
> > > @ stdcall OleCreateFromData(ptr ptr long ptr ptr ptr ptr)
> > > @ stdcall OleCreateFromDataEx(ptr ptr long long long ptr ptr ptr ptr ptr ptr ptr)
> > > @ stdcall OleCreateFromFile(ptr ptr ptr long ptr ptr ptr ptr)
> > > -@ stub OleCreateFromFileEx
> > > +@ stdcall OleCreateFromFileEx(ptr ptr ptr long long long ptr ptr ptr ptr ptr ptr ptr)
> >
> > The 2nd parameter should be str, but that's not your fault, probably
> > you've just copied and extended the OleCreateFromFile entry :)
>
> Thanks, I did exactly that. Resent.

Except, of course, they should be wstr…

Huw.