Re: version: Use proper type for third parameter of VerQueryValue

[Dmitry Timoshkov]

"James Hawkins"  wrote:
> Changelog
> - Use proper type for third parameter of VerQueryValue
> -DWORD       WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*);
> -DWORD       WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*);
> +BOOL       WINAPI VerQueryValueA(const LPVOID,LPCSTR,UINT*,UINT*);
> +BOOL       WINAPI VerQueryValueW(const LPVOID,LPCWSTR,UINT*,UINT*);

Where did you get it? PSDK agrees with current Wine definition on
the 3rd param type. Also the 2nd param should not be 'const'.

version: Use proper type for third parameter of VerQueryValue

[James Hawkins]

On Tue, 29 Mar 2005 14:02:03 +0900, Dmitry Timoshkov  wrote:
> "James Hawkins"  wrote:
> > Changelog
> > - Use proper type for third parameter of VerQueryValue
> > -DWORD       WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*);
> > -DWORD       WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*);
> > +BOOL       WINAPI VerQueryValueA(const LPVOID,LPCSTR,UINT*,UINT*);
> > +BOOL       WINAPI VerQueryValueW(const LPVOID,LPCWSTR,UINT*,UINT*);
>
> Where did you get it? PSDK agrees with current Wine definition on
> the 3rd param type. Also the 2nd param should not be 'const'.

My PSDK (Server 2003) has this definition:

BOOL VerQueryValue(
    const LPVOID pBlock,
    LPTSTR lpSubBlock,
    PUINT lplpBuffer,
    PUINT puLen
);

And msdn agrees with it:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winui...

I wrote this patch to keep up with the PSDK, but if we want to keep
the original definition, then that's cool too.  I can fix the error
when compiling visual studio another way.  What are some thoughts
about this?

version: Use proper type for third parameter of VerQueryValue

[Uwe Bonnes]

> > > > > "Dmitry" == Dmitry Timoshkov  writes:

Dmitry> "James Hawkins"  wrote:
    >> Changelog * Use proper type for third parameter of VerQueryValue

>> -DWORD WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*); -DWORD
    >> WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*); +BOOL WINAPI
    >> VerQueryValueA(const LPVOID,LPCSTR,UINT*,UINT*); +BOOL WINAPI
    >> VerQueryValueW(const LPVOID,LPCWSTR,UINT*,UINT*);

Dmitry> Where did you get it? PSDK agrees with current Wine definition
    Dmitry> on the 3rd param type. Also the 2nd param should not be 'const'.

MSDN (look with Google for VerQueryValue and use the first hit) has
(const LPVOID ..., LPTSTR ..., PUINT ..., PUINT ...)

Bye

version: Use proper type for third parameter of VerQueryValue

[Dmitry Timoshkov]

"Uwe Bonnes"  wrote:
> >> -DWORD WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*); -DWORD
> >> WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*); +BOOL WINAPI
> >> VerQueryValueA(const LPVOID,LPCSTR,UINT*,UINT*); +BOOL WINAPI
> >> VerQueryValueW(const LPVOID,LPCWSTR,UINT*,UINT*);
>
> Dmitry> Where did you get it? PSDK agrees with current Wine definition
> Dmitry> on the 3rd param type. Also the 2nd param should not be 'const'.
>
> MSDN (look with Google for VerQueryValue and use the first hit) has
> (const LPVOID ..., LPTSTR ..., PUINT ..., PUINT ...)

MSDN is known to contradict with PSDK headers. PSDK February 2003 has the following:

VerQueryValueA(
        const LPVOID pBlock,
        LPSTR lpSubBlock,
        LPVOID * lplpBuffer,
        PUINT puLen
        );
BOOL
APIENTRY
VerQueryValueW(
        const LPVOID pBlock,
        LPWSTR lpSubBlock,
        LPVOID * lplpBuffer,
        PUINT puLen
        );