Re: [PATCH] wined3d: Split comments in separate line to avoid buffer overflow when traces are enabled
On 17 February 2010 11:47, Christian Costa titan.costa@wanadoo.fr wrote:
It should use debugstr_an() in the first place. You could have a go at splitting it into separate lines if needed after that, but I can't think of a whole lot of cases where the comments are really useful.
Henri Verbeet a écrit :
On 17 February 2010 11:47, Christian Costa titan.costa@wanadoo.fr wrote:
It should use debugstr_an() in the first place. You could have a go at splitting it into separate lines if needed after that, but I can't think of a whole lot of cases where the comments are really useful.
I don't see your point using debugstr_an. My code does all the needed job. Wrt comments, having displayed the comments that explain the assembly code is not uninteresting at all imo. I'm tempted to keep then displayed.
On 17 February 2010 13:22, Christian Costa titan.costa@wanadoo.fr wrote:
I don't see your point using debugstr_an. My code does all the needed job.
It's unvalidated external data, special characters should be escaped.
Wrt comments, having displayed the comments that explain the assembly code is not uninteresting at all imo. I'm tempted to keep then displayed.
I have *never* used the comments to fixed a bug, or seen particularly interesting ones, for that matter. Regardless, if it works for you that's fine.
Wrt comments, having displayed the comments that explain the assembly code is not uninteresting at all imo. I'm tempted to keep then displayed.
I have *never* used the comments to fixed a bug, or seen particularly interesting ones, for that matter. Regardless, if it works for you that's fine.
The only use I've seen so far is matching constant numbers to HLSL uniforms. Ie, they're d3dx9.dll internal data. The usual sign for this is that the comment starts with "CTAB"
-
Christian Costa -
Henri Verbeet -
Stefan Dösinger