On Wed, Sep 7, 2011 at 09:09, Christian Costa titan.costa@wanadoo.fr wrote:
--
This series remove attrib from the builtins list. Only the brief description in the global help is kept. An externals list of commands shipped with cmd.exe is created so when the help builtins is called, the requested help is obtained by invoking the command with the /? option as for native cmd.exe.
programs/cmd/cmd.rc | 1 - programs/cmd/wcmd.h | 91 +++++++++++++++++++++++------------------------ programs/cmd/wcmdmain.c | 1 - 3 files changed, 45 insertions(+), 48 deletions(-)
You should probably commit the po changes as well, as is usually done
On Wed, 7 Sep 2011, Frédéric Delanoy wrote:
On Wed, Sep 7, 2011 at 09:09, Christian Costa titan.costa@wanadoo.fr wrote:
--
This series remove attrib from the builtins list. Only the brief description in the global help is kept. An externals list of commands shipped with cmd.exe is created so when the help builtins is called, the requested help is obtained by invoking the command with the /? option as for native cmd.exe.
[...]
You should probably commit the po changes as well, as is usually done
My understanding is that the PO files are updated automatically when Alexandre applies the patch (because he is in maintainer mode). Or did you mean that Christian should modify the translations to remove the corresponding line?
2011/9/7 Francois Gouget fgouget@free.fr:
On Wed, 7 Sep 2011, Frédéric Delanoy wrote:
On Wed, Sep 7, 2011 at 09:09, Christian Costa titan.costa@wanadoo.fr wrote:
--
This series remove attrib from the builtins list. Only the brief description in the global help is kept. An externals list of commands shipped with cmd.exe is created so when the help builtins is called, the requested help is obtained by invoking the command with the /? option as for native cmd.exe.
[...]
You should probably commit the po changes as well, as is usually done
My understanding is that the PO files are updated automatically when Alexandre applies the patch (because he is in maintainer mode). Or did you mean that Christian should modify the translations to remove the corresponding line?
The changes to the PO files would have to be committed as some point, so why not generate them yourself rather than force Alexandre to alter the patch after submission IMHO.
Maybe Alexandre can bring some light on this subject?
Frédéric
On Wed, 7 Sep 2011, Frédéric Delanoy wrote: [...]
The changes to the PO files would have to be committed as some point, so why not generate them yourself rather than force Alexandre to alter the patch after submission IMHO.
I don't think it generates more work for Alexandre. The reason for not including them would be the same as those for not including the changes to the configure script: they are automatically generated files.
The wiki does not say anything about PO files though: http://wiki.winehq.org/SubmittingPatches#head-130662b8497eb838d0fd14cbc2c9ec...
Frédéric Delanoy frederic.delanoy@gmail.com writes:
The changes to the PO files would have to be committed as some point, so why not generate them yourself rather than force Alexandre to alter the patch after submission IMHO.
Maybe Alexandre can bring some light on this subject?
It's all auto-generated, so it's better to not include the po files diffs in the patch, unless you have made manual changes.
-
Alexandre Julliard -
Francois Gouget -
Frédéric Delanoy