Jacek Caban wrote:
Hi Misha,
Misha Koshelev wrote:
We have a lot of parent/child relationships in wininet that are addressed on an individual basis. Now we can just address them within the framework since we need that framework for closing handles too. The only thing I don't like is that we have to make lots of casts now, but it doesn't really make much sense to me to store the "parent" object handle in two different places.
Sorry for late response.
This patch reverses what I've done some time ago. There is no reason to have parent object in header - you need only a child list to handle closing handles. Also casts make the code much less readable.
Thanks, Jacek
Ok, that sounds fair. I didn't really like the casts either, that was my biggest problem with this patchset. I am leaving the country tomorrow for 9 days but will change the patches/resubmit as you suggested after I come back.
Thanks for your comments.
Misha