Re: Vincent Povirk : windowscodecs: Add wrapper functions for IWICPalette methods.

[Charles Davis]

On May 10, 2012, at 1:17 PM, Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: 2fc7cdc93f6dc8ed67498b74193423c44e5bb770
> URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2fc7cdc93f6dc8ed67498b7419...
>
> Author: Vincent Povirk 
> Date:   Tue May  8 10:49:22 2012 -0500
>
> windowscodecs: Add wrapper functions for IWICPalette methods.

I have to say, these patches all seem really mechanical.

Correct me if I'm wrong, but I think MIDL has an option to generate the proxy wrappers automatically. Even if it doesn't, I'm sure this would be a good feature to add to widl (if we don't already have it) so we don't have to laboriously write and maintain each and every one of the proxy wrappers.

Chip

Vincent Povirk : windowscodecs: Add wrapper functions for IWICPalette methods.

[Vincent Povirk]

Yes, it is very mechanical.

The Proxy functions that widl generates are not the same kind of
function that are exported from windowscodecs. From what I can tell,
all these functions do is call a method on a COM interface. Also, not
every COM method in WIC has a Proxy export.

If I had to guess, I'd say that someone exported these early in WIC's
development (maybe originally leading to actual COM proxy functions,
which would have been confusing for everyone except us, instead of
just confusing for us), someone pointed out how silly that was, and
they had to leave the exports in because of existing code that was
using it.

I don't expect to see new proxy exports, nor do I expect to see them
in any other libraries. So I figured it made more sense to do them all
manually than to come up with an automated process.

On Thu, May 10, 2012 at 7:16 PM, Charles Davis  wrote:
> On May 10, 2012, at 1:17 PM, Alexandre Julliard wrote:
> > Module: wine
> > Branch: master
> > Commit: 2fc7cdc93f6dc8ed67498b74193423c44e5bb770
> > URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2fc7cdc93f6dc8ed67498b7419...
> >
> > Author: Vincent Povirk 
> > Date:   Tue May  8 10:49:22 2012 -0500
> >
> > windowscodecs: Add wrapper functions for IWICPalette methods.
>
> I have to say, these patches all seem really mechanical.
>
> Correct me if I'm wrong, but I think MIDL has an option to generate the proxy wrappers automatically. Even if it doesn't, I'm sure this would be a good feature to add to widl (if we don't already have it) so we don't have to laboriously write and maintain each and every one of the proxy wrappers.
>
> Chip