Re: [PATCH 9/9] gdiplus: Add pixel format test for transparent non-animated gif (try3)

[Dmitry Timoshkov]

Piotr Caban  wrote:
> dlls/gdiplus/tests/image.c | 30 ++++++++++++++++++++++++++++++
>   1 file changed, 30 insertions(+)

Please add the tests similar to the animated case which checks pixel data,
also add the tests for the palette to see that it actually has a trasparent
color. Otherwise it's hard to see what is going on, and my skills of reading
binary gif data becomes rusty with time.

[PATCH 9/9] gdiplus: Add pixel format test for transparent non-animated gif (try3)

[Piotr Caban]

On 03/12/15 10:54, Dmitry Timoshkov wrote:
> Piotr Caban  wrote:
> > dlls/gdiplus/tests/image.c | 30 ++++++++++++++++++++++++++++++
> >    1 file changed, 30 insertions(+)
>
> Please add the tests similar to the animated case which checks pixel data,
> also add the tests for the palette to see that it actually has a trasparent
> color. Otherwise it's hard to see what is going on, and my skills of reading
> binary gif data becomes rusty with time.

I'll do it, but I really think this doesn't belong to this patch series. 
It works exactly the same as it worked without my changes.

Thanks,
Piotr

[PATCH 9/9] gdiplus: Add pixel format test for transparent non-animated gif (try3)

[Dmitry Timoshkov]

Piotr Caban  wrote:
> > Please add the tests similar to the animated case which checks pixel data,
> > also add the tests for the palette to see that it actually has a trasparent
> > color. Otherwise it's hard to see what is going on, and my skills of reading
> > binary gif data becomes rusty with time.
>
> I'll do it, but I really think this doesn't belong to this patch series. 
> It works exactly the same as it worked without my changes.

That's fine, thanks Piotr.

[PATCH 9/9] gdiplus: Add pixel format test for transparent non-animated gif (try3)

[Piotr Caban]

On 03/12/15 11:04, Dmitry Timoshkov wrote:
> > > Please add the tests similar to the animated case which checks pixel data,
> > > also add the tests for the palette to see that it actually has a trasparent
> > > color. Otherwise it's hard to see what is going on, and my skills of reading
> > > binary gif data becomes rusty with time.

Here's the test that you were asking about (it's generated on top of the 
patches I've sent to wine-patches). The testbot results will be here:
https://newtestbot.winehq.org/JobDetails.pl?Key=12111

I'm going to send it to wine-patches when GIF composition patches are 
in. It adds some changes to get_palette function because palette flags 
are set incorrectly.

Thanks,
Piotr