MSCMS tests fails on my box:
| [s2@katleriai wine]$ wine dlls/mscms/tests/mscms_test.exe.so 2>&1 | head -n 6 | This version of Wine was compiled without support for color management | functions. This means many color functions are empty stubs and you should | expect your application to fail. To enable Wine to use LittleCMS for color | management please install a liblcms development package version 1.13 or | higher and rebuild Wine. | http://www.littlecms.com
I want to fix this by avoiding to upgrade my liblcms and install dev-pkg.
Would it be OK to put some #ifdef-s in some unimplemented function, let say EnumColorProfilesA(), and to SetLastError(ERROR_CALL_NOT_IMPLEMENTED)?
Then at the start of the test we could check this and return from the test when GetLastError() return ERROR_CALL_NOT_IMPLEMENTED. Is this way OK?
On Tuesday 28 June 2005 22:11, Saulius Krasuckas wrote:
| [s2@katleriai wine]$ wine dlls/mscms/tests/mscms_test.exe.so 2>&1 | head -n 6 | This version of Wine was compiled without support for color management | functions. This means many color functions are empty stubs and you should | expect your application to fail. To enable Wine to use LittleCMS for color | management please install a liblcms development package version 1.13 or | higher and rebuild Wine. | http://www.littlecms.com
I want to fix this by avoiding to upgrade my liblcms and install dev-pkg.
What version do you have? 1.09 is reported to work too, so maybe we should change our requirement. 1.13 is just the version I developed against so I was sure Wine worked with that version.
Would it be OK to put some #ifdef-s in some unimplemented function, let say EnumColorProfilesA(), and to SetLastError(ERROR_CALL_NOT_IMPLEMENTED)?
Well, I think Wine tests are supposed to identify Windows behavior, and no version of Windows does what you propose for these functions AFAIK. We could fail to load mscms.dll if it was compiled without lcms support, but then your app (or test) would fail too and as a whole. In the current situation you might be able to use your app partly. Some tests may even succeed if the functions they test don't depend on lcms.
-Hans
* On Wed, 29 Jun 2005, Hans Leidekker wrote:
- On Tuesday 28 June 2005 22:11, Saulius Krasuckas wrote:
I want to fix this by avoiding to upgrade my liblcms and install dev-pkg.
What version do you have? 1.09 is reported to work too, so maybe we should change our requirement. 1.13 is just the version I developed against so I was sure Wine worked with that version.
| [s2@katleriai s2]$ ll `locate liblcms.so` | lrwxrwxrwx 1 root root 17 May 16 2004 /usr/lib/liblcms.so.1 -> liblcms.so.1.0.12 | -rwxr-xr-x 1 root root 203722 Feb 3 2004 /usr/lib/liblcms.so.1.0.12
My point is not to check whether 1.0.12 version works. I want the tests to pass.
Would it be OK to put some #ifdef-s in some unimplemented function, let say EnumColorProfilesA(), and to SetLastError(ERROR_CALL_NOT_IMPLEMENTED)?
Well, I think Wine tests are supposed to identify Windows behavior, and no version of Windows does what you propose for these functions AFAIK. We could fail to load mscms.dll if it was compiled without lcms support, but then your app (or test) would fail too and as a whole.
And "make test" will fail in such case too. Bad idea.
In the current situation you might be able to use your app partly. Some tests may even succeed if the functions they test don't depend on lcms.
There is no app I am interested in. I just want dlls/mscms/tests to pass even w/o LittleCMS support. Is such my target wrong?
On Wednesday 29 June 2005 14:10, Saulius Krasuckas wrote:
Well, I think Wine tests are supposed to identify Windows behavior, and no version of Windows does what you propose for these functions AFAIK. We could fail to load mscms.dll if it was compiled without lcms support, but then your app (or test) would fail too and as a whole.
And "make test" will fail in such case too. Bad idea.
Windows 95/NT4 don't have mscms.dll IIRC, so we would have to catch this case anyway, and then we could simply skip the tests.
-Hans
-
Hans Leidekker -
Saulius Krasuckas