Signed-off-by: Zebediah Figura z.figura12@gmail.com --- In an attempt to address failures like http://test.winehq.org/data/931408698859360e56cd85d532b142e789a6c274/vista_newtb-wvistau64-fr-32/quartz:systemclock.html and http://test.winehq.org/data/717109ce79bbf92b5e3e93e49f96b78ece00a952/win7_fg-win7u64-1spie9-es/quartz:filtergraph.html.
dlls/quartz/tests/filtergraph.c | 2 +- dlls/quartz/tests/systemclock.c | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c index 14f2dfaa7a..4b233dbcff 100644 --- a/dlls/quartz/tests/filtergraph.c +++ b/dlls/quartz/tests/filtergraph.c @@ -512,7 +512,7 @@ static void test_media_event(IFilterGraph2 *graph)
while (!got_eos) { - if (WaitForSingleObject(event, 2000) == WAIT_TIMEOUT) + if (WaitForSingleObject(event, 5000) == WAIT_TIMEOUT) break;
while ((hr = IMediaEvent_GetEvent(media_event, &code, &lparam1, &lparam2, 0)) == S_OK) diff --git a/dlls/quartz/tests/systemclock.c b/dlls/quartz/tests/systemclock.c index 3c493a0f38..fa1ab6856b 100644 --- a/dlls/quartz/tests/systemclock.c +++ b/dlls/quartz/tests/systemclock.c @@ -120,8 +120,8 @@ static void test_advise(void)
hr = IReferenceClock_AdviseTime(clock, current, 500 * 10000, (HEVENT)event, &cookie); ok(hr == S_OK, "Got hr %#x.\n", hr); - ok(WaitForSingleObject(event, 480) == WAIT_TIMEOUT, "Event should not be signaled.\n"); - ok(!WaitForSingleObject(event, 40), "Event should be signaled.\n"); + ok(WaitForSingleObject(event, 460) == WAIT_TIMEOUT, "Event should not be signaled.\n"); + ok(!WaitForSingleObject(event, 80), "Event should be signaled.\n");
hr = IReferenceClock_Unadvise(clock, cookie); ok(hr == S_FALSE, "Got hr %#x.\n", hr); @@ -133,15 +133,15 @@ static void test_advise(void) ok(hr == S_OK, "Got hr %#x.\n", hr); hr = IReferenceClock_Unadvise(clock, cookie); ok(hr == S_OK, "Got hr %#x.\n", hr); - ok(WaitForSingleObject(event, 520) == WAIT_TIMEOUT, "Event should not be signaled.\n"); + ok(WaitForSingleObject(event, 540) == WAIT_TIMEOUT, "Event should not be signaled.\n");
ResetEvent(event); hr = IReferenceClock_GetTime(clock, ¤t); ok(SUCCEEDED(hr), "Got hr %#x.\n", hr); hr = IReferenceClock_AdviseTime(clock, current + 500 * 10000, 0, (HEVENT)event, &cookie); ok(hr == S_OK, "Got hr %#x.\n", hr); - ok(WaitForSingleObject(event, 480) == WAIT_TIMEOUT, "Event should not be signaled.\n"); - ok(!WaitForSingleObject(event, 40), "Event should be signaled.\n"); + ok(WaitForSingleObject(event, 460) == WAIT_TIMEOUT, "Event should not be signaled.\n"); + ok(!WaitForSingleObject(event, 80), "Event should be signaled.\n");
hr = IReferenceClock_GetTime(clock, ¤t); ok(SUCCEEDED(hr), "Got hr %#x.\n", hr);
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=58778
Your paranoid android.
=== w1064v1809_zh_CN (32 bit report) ===
quartz: filtergraph.c:3932: Test failed: Expected about 1334ms, got d37ca0. filtergraph.c:3937: Test failed: Expected about 1334ms, got d37ca0. filtergraph.c:3950: Test failed: Expected about 1334ms, got d21d10. filtergraph.c:3955: Test failed: Expected about 1334ms, got d26b30.
=== w1064v1809_he (32 bit report) ===
quartz: systemclock.c:166: Test failed: Semaphore should not be signaled. systemclock.c:167: Test failed: Semaphore should be signaled.
=== debian10 (64 bit WoW report) ===
quartz: filtergraph: Timeout
-
Marvin -
Zebediah Figura