Re: winex11: add alternative header

[Steven Edwards]

2009/9/18 André Hentschel :
> this is my first patch to autoconf-stuff, please tell me if i did something wrong
> see also Bug 20070

I expect It should actually not look like the following
> #ifdef HAVE_X11_EXTENSIONS_XF86VMODE_H
>  #include <X11/extensions/xf86vmode.h>
> +#elif defined (HAVE_X11_EXTENSIONS_XF86VMPROTO_H)
> +#include <X11/extensions/xf86vmproto.h>
>  #endif

and instead like this:

#ifdef HAVE_X11_EXTENSIONS_XF86VMODE_H
#include <X11/extensions/xf86vmode.h>
#endif
#ifdef HAVE_X11_EXTENSIONS_XF86VMPROTO_H
#include <X11/extensions/xf86vmproto.h>
#endif

Thanks

winex11: add alternative header

[André Hentschel]

Steven Edwards schrieb:
> 2009/9/18 André Hentschel :
> > this is my first patch to autoconf-stuff, please tell me if i did something wrong
> > see also Bug 20070
>
> I expect It should actually not look like the following
> > #ifdef HAVE_X11_EXTENSIONS_XF86VMODE_H
> >  #include <X11/extensions/xf86vmode.h>
> > +#elif defined (HAVE_X11_EXTENSIONS_XF86VMPROTO_H)
> > +#include <X11/extensions/xf86vmproto.h>
> >  #endif
>
> and instead like this:
>
> #ifdef HAVE_X11_EXTENSIONS_XF86VMODE_H
> #include <X11/extensions/xf86vmode.h>
> #endif
> #ifdef HAVE_X11_EXTENSIONS_XF86VMPROTO_H
> #include <X11/extensions/xf86vmproto.h>
> #endif
>
> Thanks

Thanks for the hint, i had this construction from http://www.winehq.org/site/docs/winedev-guide/porting (which might be outdated)
ill send a try 2

winex11: add alternative header

[Steven Edwards]

2009/9/19 André Hentschel :
> Thanks for the hint, i had this construction from http://www.winehq.org/site/docs/winedev-guide/porting (which might be outdated)
> ill send a try 2

Yes I think the guide is wrong or at least misleading. If the #elif
case is there its not very common, at least in all the header patches
I've ever submitted for porting related issues. I've seen it used
plenty of times like the guide says for checking differing
implementation of functions and the like.