Re: [PATCH 1/7] vbscript: Implemented Cos(try 2)

[Jacek Caban]

On 08/14/14 17:23, Shuai Meng wrote:
> Change log:
>   Applied cleanly.
>
> dlls/vbscript/global.c      | 10 ++++++++--
>  dlls/vbscript/tests/api.vbs | 19 +++++++++++++++++++
>  2 files changed, 27 insertions(+), 2 deletions(-)

Please add some tests for values other than trivial cases. You may want
to add PI constant and a helper (like almostEqual) to deal with
precision problems. Same applies to other patches from this series.
Also, for functions (like atan) that have invalid arguments, I'd like to
see tests of them.

Jacek