[PATCH] wsdapi/tests: Fix a memory leak (Valgrind).

[Sven Baars]

Signed-off-by: Sven Baars 
---
 dlls/wsdapi/tests/xml.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/wsdapi/tests/xml.c b/dlls/wsdapi/tests/xml.c
index 633124f1b1..ab86d23166 100644
--- a/dlls/wsdapi/tests/xml.c
+++ b/dlls/wsdapi/tests/xml.c
@@ -604,6 +604,7 @@ static void XMLContext_AddNameToNamespace_tests(void)
         /* Apparently wsdapi always leaves the namespace names array as empty */
         ok(ns2->Names == NULL, "Names array is not empty\n");
         ok(ns2->NamesCount == 0, "NamesCount is not 0 (value = %d)\n", ns2->NamesCount);
+        WSDFreeLinkedMemory(ns2);
     }

IWSDXMLContext_Release(context);

[PATCH] wsdapi: Fix some memory leaks (Valgrind).

[Sven Baars]

Signed-off-by: Sven Baars 
---
 dlls/wsdapi/soap.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/dlls/wsdapi/soap.c b/dlls/wsdapi/soap.c
index 2ecc01313f..91c541a784 100644
--- a/dlls/wsdapi/soap.c
+++ b/dlls/wsdapi/soap.c
@@ -1426,6 +1426,8 @@ static HRESULT ws_element_to_wsdxml_element(WS_XML_READER *reader, IWSDXMLContex
                 if (FAILED(ret)) goto cleanup;
                 WSDXMLAddChild(cur_element, element);

+                WSDFreeLinkedMemory(name);
+
                 cur_wsd_attrib = NULL;

/* Add attributes */
@@ -1712,7 +1714,7 @@ HRESULT read_message(IWSDiscoveryPublisherImpl *impl, const char *xml, int xml_l
     IWSDXMLContext *context = NULL;
     WS_XML_STRING *soap_uri = NULL;
     const WS_XML_NODE *node;
-    WS_XML_READER *reader;
+    WS_XML_READER *reader = NULL;
     LPCWSTR value = NULL;
     LPWSTR uri, prefix;
     WS_HEAP *heap;
@@ -1945,6 +1947,7 @@ cleanup:
     free_xml_string(soap_uri);
     WSDFreeLinkedMemory(soap_msg);
     if (context != NULL) IWSDXMLContext_Release(context);
+    if (reader != NULL) WSFreeReader(reader);

return ret;
 }

[PATCH] wsdapi: Fix some memory leaks (Valgrind).

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=45906

Your paranoid android.

=== debian9 (build log) ===

collect2: error: ld returned 1 exit status
Makefile:434: recipe for target 'wsdapi.dll.so' failed
Makefile:8648: recipe for target 'dlls/wsdapi' failed
Task: The win32 build failed

=== debian9 (build log) ===

collect2: error: ld returned 1 exit status
Makefile:432: recipe for target 'wsdapi.dll.so' failed
Makefile:8371: recipe for target 'dlls/wsdapi' failed
Task: The wow64 build failed