2008/11/18 Stefan Dösinger stefan@codeweavers.com:
I think it would be better f getColorBits returned a proper error to the caller, and the caller handles these errors without spamming the FIXME or ERR channel. That would seem better to me than prefiltering the parameters
It does, it returns FALSE for "unsupported" formats. The only thing the patch fixes is the FIXME & ERR output. I think there are places where we'd like getColorBits() to work properly for float formats though.