Re: OLEAUT32: Output a FIXME message only once.

[Cihan Altinay]

Hi,

Mike McCormack wrote:
> Unless somebody is planning to fix this soon, it would be nice to just
> output it once to remind us that it needs to be fixed later.  It's a
> memory leak, so it's not worth frightening our users more than once over.
>
> Mike
>
> ChangeLog:
> Output a FIXME message only once.
>
> dlls/oleaut32/typelib.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> a06a1b1d8dbb246eede84fd894e273641477d1fc
> diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c
> index 4ef590e..70c1d1f 100644
> --- a/dlls/oleaut32/typelib.c
> +++ b/dlls/oleaut32/typelib.c
> @@ -4287,7 +4287,12 @@ static ULONG WINAPI ITypeInfo_fnRelease(
>           it means that function is called by ITypeLib2_Release */
>        ITypeLib2_Release((ITypeLib2*)This->pTypeLib);
>      } else   {
> -
>  FIXME("destroy child objects\n");
> -
>  static int once = 0;
> -
>  if (once)

I think it should read
    if (!once)
:-)
> -
>  {
> -
>      once = 1;
> -
>      FIXME("destroy child objects\n");
> -
>  }
>
>  TRACE("destroying ITypeInfo(%p)\n",This);
>  if (This->Name)

Cihan