Re: [PATCH 2/3] wined3d: Pass a struct wined3d_bo_address to read_from_framebuffer.

[Henri Verbeet]

On 28 November 2013 10:48, Stefan Dösinger  wrote:
> /* Read the framebuffer back into the surface */
> -static void read_from_framebuffer(struct wined3d_surface *surface, void *dest, UINT pitch)
> +static void read_from_framebuffer(struct wined3d_surface *surface,
> -
>    const struct wined3d_bo_address *data, UINT pitch)

It seems a bit silly to pass these as parameters when the only caller
gets them from the surface.

[PATCH 2/3] wined3d: Pass a struct wined3d_bo_address to read_from_framebuffer.

[Stefan Dösinger]

Am 28.11.2013 um 15:56 schrieb Henri Verbeet :
> On 28 November 2013 10:48, Stefan Dösinger  wrote:
> > /* Read the framebuffer back into the surface */
> > -static void read_from_framebuffer(struct wined3d_surface *surface, void *dest, UINT pitch)
> > +static void read_from_framebuffer(struct wined3d_surface *surface,
> > -
> >    const struct wined3d_bo_address *data, UINT pitch)
>
> It seems a bit silly to pass these as parameters when the only caller
> gets them from the surface.

It keeps the switch between resource->allocatedMemory and PBO in a central place. My goal is to remove resource->allocatedMemory and have surface_get_data and surface_map choose between PBO, heap_memory, user-memory set by surface_set_memory and the DIB.

[PATCH 2/3] wined3d: Pass a struct wined3d_bo_address to read_from_framebuffer.

[Stefan Dösinger]

Am 28.11.2013 17:07 schrieb "Stefan Dösinger" :
> Am 28.11.2013 um 15:56 schrieb Henri Verbeet :
> > On 28 November 2013 10:48, Stefan Dösinger

wrote:
> > > /* Read the framebuffer back into the surface */
> > > -static void read_from_framebuffer(struct wined3d_surface *surface,

void *dest, UINT pitch)
> > > +static void read_from_framebuffer(struct wined3d_surface *surface,
> > > -
> > >    const struct wined3d_bo_address *data, UINT pitch)
> >
> > It seems a bit silly to pass these as parameters when the only caller
> > gets them from the surface.
>
> It keeps the switch between resource->allocatedMemory and PBO in a

central place. My goal is to remove resource->allocatedMemory and have
surface_get_data and surface_map choose between PBO, heap_memory,
user-memory set by surface_set_memory and the DIB.
>

I guess you meant that I can call surface_get_memory in the function
itself...