Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces
Eric Pouech eric.pouech@orange.fr wrote:
Eric Pouech eric.pouech@orange.fr wrote:
Gdb uses decimal notation by default for integers, so do we.
GDB can use anything their developers think appropriate, my patch to use hex was intended to match Wine's relay traces and win32 header constants. This patch will make finding matches impossible again.
bt /x will do what you want.
How will it help with all those backtraces generated and sent by users to bugzilla? Or those intermittent crashes which are very hard to reproduce? Is there any reason to spend any time again if all required information is already there in appropriate and ready to use/easy to understand format?
bt /x will do what you want.
How will it help with all those backtraces generated and sent by users to bugzilla? Or those intermittent crashes which are very hard to reproduce? Is there any reason to spend any time again if all required information is already there in appropriate and ready to use/easy to understand format?
if it's information sent by user (in any form), you can always write a small script to do the job (and also extend, message number, styles...) A+
Eric Pouech eric.pouech@orange.fr wrote:
bt /x will do what you want.
How will it help with all those backtraces generated and sent by users to bugzilla? Or those intermittent crashes which are very hard to reproduce? Is there any reason to spend any time again if all required information is already there in appropriate and ready to use/easy to understand format?
if it's information sent by user (in any form), you can always write a small script to do the job (and also extend, message number, styles...)
Can I ask again, why to jump through the hoops if all required information is already there in appropriate and ready to use/easy to understand format?
Dmitry Timoshkov a écrit :
Eric Pouech eric.pouech@orange.fr wrote:
bt /x will do what you want.
How will it help with all those backtraces generated and sent by users to bugzilla? Or those intermittent crashes which are very hard to reproduce? Is there any reason to spend any time again if all required information is already there in appropriate and ready to use/easy to understand format?
if it's information sent by user (in any form), you can always write a small script to do the job (and also extend, message number, styles...)
Can I ask again, why to jump through the hoops if all required information is already there in appropriate and ready to use/easy to understand format?
because others users want information in decimal, as any other debugger does. and I do.
A+
Eric Pouech eric.pouech@orange.fr wrote:
Can I ask again, why to jump through the hoops if all required information is already there in appropriate and ready to use/easy to understand format?
because others users want information in decimal, as any other debugger does. and I do.
It doesn't really matter what other debuggers do. But it does matter to have backtraces and general output in hex because this: 1. matches Wine relay logs 2. helps to easily recognize things like user and gdi handles, relative to module and heap base offsets, window styles, messages, many special constants which are in hex in win32, wine internal messages, WM_USER/WM_APP+xxx/common controls messages 3. a lot of other things
I do care, because I have to dayly look at huge amount of logs, and having backtraces print data in hex makes my life enormously easiler.
On 19 March 2010 10:03, Dmitry Timoshkov dmitry@codeweavers.com wrote:
I do care, because I have to dayly look at huge amount of logs, and having backtraces print data in hex makes my life enormously easiler.
I don't care as strongly, but I agree with Dmitry that hexadecimal is more convenient.
Dmitry Timoshkov a écrit :
Eric Pouech eric.pouech@orange.fr wrote:
Can I ask again, why to jump through the hoops if all required information is already there in appropriate and ready to use/easy to understand format?
because others users want information in decimal, as any other debugger does. and I do.
It doesn't really matter what other debuggers do. But it does matter to have backtraces and general output in hex because this:
- matches Wine relay logs
- helps to easily recognize things like user and gdi handles, relative to
module and heap base offsets, window styles, messages, many special constants which are in hex in win32, wine internal messages, WM_USER/WM_APP+xxx/common controls messages 3. a lot of other things
I do care, because I have to dayly look at huge amount of logs, and having backtraces print data in hex makes my life enormously easiler.
hmm sounds like most of the code we have in not in sync
[eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*d" | wc -l 8767 [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*x" | wc -l 4136
A+
hmm sounds like most of the code we have in not in sync
[eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*d" | wc -l 8767 [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*x" | wc -l 4136
This isn't a meaningful measurement. A %d may be used in a trace after unpacking elements out of a flags/item combination, while a %x would be used in e.g. a relay trace. --Juan
Juan Lang a écrit :
hmm sounds like most of the code we have in not in sync
[eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*d" | wc -l 8767 [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*x" | wc -l 4136
This isn't a meaningful measurement. A %d may be used in a trace after unpacking elements out of a flags/item combination, while a %x would be used in e.g. a relay trace. --Juan
my point is just saying that 2/3 of the information put in traces is in decimal which is a measurement of what is expected as format for integral values A+
my point is just saying that 2/3 of the information put in traces is in decimal which is a measurement of what is expected as format for integral values
Yes, I understand. And I'm saying that such an estimate likely overstates the utility of decimal format for integral values, because the trace may well mask out the bits that would make a hexadecimal trace confusing.
Note that I don't have a firm opinion over the best format in winedbg, I'm all for changing it if it makes sense, but this argument doesn't lend support to your position, IMO. --Juan
Eric Pouech eric.pouech@orange.fr wrote:
hmm sounds like most of the code we have in not in sync
[eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*d" | wc -l 8767 [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*x" | wc -l 4136
I specifiacally mentioned relay traces, not every TRACE statement in every module.
Dmitry Timoshkov a écrit :
Eric Pouech eric.pouech@orange.fr wrote:
hmm sounds like most of the code we have in not in sync
[eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*d" | wc -l 8767 [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*x" | wc -l 4136
I specifiacally mentioned relay traces, not every TRACE statement in every module.
my point was not just to say that most of the information put in current TRACE/WARN/FIXME/ERR statements contain more decimal than hexadecimal formats so obviously, not everybody expects hexa all over the place A+
Eric Pouech eric.pouech@orange.fr wrote:
my point was not just to say that most of the information put in current TRACE/WARN/FIXME/ERR statements contain more decimal than hexadecimal formats so obviously, not everybody expects hexa all over the place
Of course each TRACE statements serve the pupose of each particular place in the code it's placed in.
A backtrace is meaningful only in the context of a relay trace, so it should match the format of relay traces in the first place (besides other reasons I mentioned earlier).
-
Dmitry Timoshkov -
Eric Pouech -
Henri Verbeet -
Juan Lang