-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
Am 2014-01-17 02:07, schrieb Alistair Leslie-Hughes:
Added server tests.
I noticed that you still have style inconsistencies in these patches.
I haven't done a deeper review of the content yet. I'll get to that once I'm done with my own patches :-\ .
Hi Stefan,
Added server tests.
I noticed that you still have style inconsistencies in these patches.
I'll have another look.
The code in dpnet is already inconsistent with 2/4 space indents within each file. Don't know exactly how to clean that up.
Alistair.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2014-01-17 12:29, schrieb Alistair Leslie-Hughes:
The code in dpnet is already inconsistent with 2/4 space indents within each file. Don't know exactly how to clean that up.
The usual way is to pick a new style you and whoever else is working on the code like and write all new code in the new style. Leave old lines alone until you touch them for some other reason.
Personally I recommend the style we're using in wined3d, see e.g. dlls/wined3d/cs.c for a file that is "pure". As far as I can see that matches the style in wineserver, except for
/* wined3d */ if (foo) a(); else b();
vs
/* wineserver */ if (foo) a(); else b();
But in the end its up to you if you intend to do more work on dplay.
My personal opinion is that we should unify the entire code once with an automated tool and bite the bullet wrt this breaking git blame. IMO we have more problems with contributors not finding their way around the style requirements than the inconvenience this will cause with git blame for a while. But this is just my opinion, not the Wine project's.
-
Alistair Leslie-Hughes -
Stefan Dösinger