Re:activeds: add stub for ADsGetLastError

[Louis. Lenders]

Thanks for reviewing the patch James
@@ -6,7 +6,7 @@
 8 stub ADsBuildVarArrayInt
 9 stdcall ADsOpenObject(wstr wstr wstr long ptr ptr)
 12 stub ADsSetLastError
-13 stub ADsGetLastError
+13 stdcall ADsGetLastError(ptr wstr long wstr long)
> Both of those wstr parameters are out pointers so they should be ptr, not wstr.

Didn't know that, so that has to be changed for sure

/*****************************************************
+ * ADsGetLastError    [ACTIVEDS.13]
+ */
+HRESULT WINAPI ADsGetLastError(LPDWORD pError, LPWSTR buffer, DWORD
buflen, LPWSTR bufname, DWORD bufnamelen)
+{
+    FIXME("(%p,%p,%d,%p,%d)stub\n", pError, buffer, buflen, bufname,
bufnamelen);
+    return E_POINTER;
+}
> Returning E_POINTER seems pretty wrong.

In the documentation on http://msdn.microsoft.com/en-us/library/aa772183(VS.85).aspx
it is listed as one of the possible return values. Of course one could also return E_NOTIMPL or E_FAIL etc, but for a stub this seemed like a good choice to me as well, the application (Dameware) doesn't seem to bother what is returned, it starts up just fine

Send instant messages to your online friends http://uk.messenger.yahoo.com

activeds: add stub for ADsGetLastError

[James Hawkins]

On Thu, Aug 21, 2008 at 2:13 PM, Louis. Lenders
 wrote:
> Thanks for reviewing the patch James
> @@ -6,7 +6,7 @@
>  8 stub ADsBuildVarArrayInt
>  9 stdcall ADsOpenObject(wstr wstr wstr long ptr ptr)
>  12 stub ADsSetLastError
> -13 stub ADsGetLastError
> +13 stdcall ADsGetLastError(ptr wstr long wstr long)
> > Both of those wstr parameters are out pointers so they should be ptr, not
> > wstr.
>
> Didn't know that, so that has to be changed for sure
>
> /*****************************************************
> -
> - ADsGetLastError    [ACTIVEDS.13]
> - */
>
> +HRESULT WINAPI ADsGetLastError(LPDWORD pError, LPWSTR buffer, DWORD
> buflen, LPWSTR bufname, DWORD bufnamelen)
> +{
> - FIXME("(%p,%p,%d,%p,%d)stub\n", pError, buffer, buflen, bufname,
>
> bufnamelen);
> - return E_POINTER;
>
> +}
> > Returning E_POINTER
>
> seems pretty wrong.
>
> In the documentation on
> http://msdn.microsoft.com/en-us/library/aa772183(VS.85).aspx
> it is listed as one of the possible return values. Of course one could also
> return E_NOTIMPL or E_FAIL etc, but for a stub this seemed like a good
> choice to me as well, the application (Dameware) doesn't seem to bother what
> is returned, it starts up just fine

Sure it's one of several possible return values, but not necessarily
appropriate for a stub function.  Both E_NOTIMPL and E_FAIL are better
choices.